Skip to content

Changed tensor comparison return type from uint8 to bool (#21113) #23789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
izdeby wants to merge 1 commit into from
Closed

Changed tensor comparison return type from uint8 to bool (#21113) #23789

izdeby wants to merge 1 commit into from

Conversation

@izdeby
Copy link
Contributor

@izdeby izdeby commented Aug 5, 2019

Summary:
Pull Request resolved: #21113
ghimport-source-id: 9c4ba63

Test Plan: Imported from OSS

Differential Revision: D15552204

Pulled By: izdeby

fbshipit-source-id: a608213668649d058e22b510d7755cb99e7d0037

@izdeby
Changed tensor comparison return type from uint8 to bool (#21113)
e3c0b65 
Summary:
Pull Request resolved: #21113
ghimport-source-id: 9c4ba63

Test Plan: Imported from OSS

Differential Revision: D15552204

Pulled By: izdeby

fbshipit-source-id: a608213668649d058e22b510d7755cb99e7d0037
@pytorchbot pytorchbot added oncall: jit Add this issue/PR to JIT oncall triage queue module: cpu CPU specific problem (e.g., perf, algorithm) module: cuda Related to torch.cuda, and CUDA support in general oncall: distributed Add this issue/PR to distributed oncall triage queue module: internals Related to internal abstractions in c10 and ATen module: onnx Related to torch.onnx module: operators module: pybind Related to our Python bindings / interactions with other Python libraries module: tests Issues related to tests (not the torch.testing module) labels Aug 5, 2019
@izdeby izdeby mentioned this pull request Aug 5, 2019
Closed
@izdeby izdeby requested a review from soumith August 5, 2019 17:46
@gchanan gchanan mentioned this pull request Aug 5, 2019
Closed
@izdeby
Copy link
Contributor Author

izdeby commented Aug 5, 2019

Merged at 3314b57

@izdeby izdeby closed this Aug 5, 2019
@facebook-github-bot facebook-github-bot deleted the mergeBoolComp branch July 13, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soumith soumith Awaiting requested review from soumith

Assignees

No one assigned

Labels

module: cpu CPU specific problem (e.g., perf, algorithm) module: cuda Related to torch.cuda, and CUDA support in general module: internals Related to internal abstractions in c10 and ATen module: onnx Related to torch.onnx module: pybind Related to our Python bindings / interactions with other Python libraries module: tests Issues related to tests (not the torch.testing module) oncall: distributed Add this issue/PR to distributed oncall triage queue oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@izdeby @pytorchbot