Allow kernels that don't have a boxed version #23665
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For many ATen ops, c10 can't generate boxed kernel versions yet. We need to allow kernels that have only unboxed versions for them to be registerable with c10. Differential Revision: [D16603132](https://our.internmc.facebook.com/intern/diff/D16603132/)
pytorchbot
added
the
module: internals
This was referenced Aug 1, 2019
For many ATen ops, c10 can't generate boxed kernel versions yet. We need to allow kernels that have only unboxed versions for them to be registerable with c10. Differential Revision: [D16603132](https://our.internmc.facebook.com/intern/diff/D16603132/)
This was referenced Aug 1, 2019
Closed
dzhulgakov
approved these changes
Aug 2, 2019
For many ATen ops, c10 can't generate boxed kernel versions yet. We need to allow kernels that have only unboxed versions for them to be registerable with c10. Differential Revision: [D16603132](https://our.internmc.facebook.com/intern/diff/D16603132/)
For many ATen ops, c10 can't generate boxed kernel versions yet. We need to allow kernels that have only unboxed versions for them to be registerable with c10. Differential Revision: [D16603132](https://our.internmc.facebook.com/intern/diff/D16603132/)
For many ATen ops, c10 can't generate boxed kernel versions yet. We need to allow kernels that have only unboxed versions for them to be registerable with c10. Differential Revision: [D16603132](https://our.internmc.facebook.com/intern/diff/D16603132/)
This was referenced Aug 5, 2019
For many ATen ops, c10 can't generate boxed kernel versions yet. We need to allow kernels that have only unboxed versions for them to be registerable with c10. Differential Revision: [D16603132](https://our.internmc.facebook.com/intern/diff/D16603132/)
For many ATen ops, c10 can't generate boxed kernel versions yet. We need to allow kernels that have only unboxed versions for them to be registerable with c10. Differential Revision: [D16603132](https://our.internmc.facebook.com/intern/diff/D16603132/)
For many ATen ops, c10 can't generate boxed kernel versions yet. We need to allow kernels that have only unboxed versions for them to be registerable with c10. Differential Revision: [D16603132](https://our.internmc.facebook.com/intern/diff/D16603132/)
For many ATen ops, c10 can't generate boxed kernel versions yet. We need to allow kernels that have only unboxed versions for them to be registerable with c10. Differential Revision: [D16603132](https://our.internmc.facebook.com/intern/diff/D16603132/)
Contributor
|
This pull request has been merged in 296f218. |
25 tasks
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 9, 2019
Summary: Pull Request resolved: pytorch/pytorch#23665 For many ATen ops, c10 can't generate boxed kernel versions yet. We need to allow kernels that have only unboxed versions for them to be registerable with c10. ghstack-source-id: 88050429 Differential Revision: D16603132 fbshipit-source-id: 84cae4a514da104f5035d23a4059ca6197469f9c
yf225
pushed a commit
to yf225/pytorch
that referenced
this pull request
Aug 11, 2019
This reverts commit 296f218.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
For many ATen ops, c10 can't generate boxed kernel versions yet.
We need to allow kernels that have only unboxed versions for them to be registerable with c10.
Differential Revision: D16603132