Skip to content

Fix pin_memory_thread not exiting quickly #23646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ssnl wants to merge 1 commit into from
Closed

Fix pin_memory_thread not exiting quickly #23646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion torch/utils/data/_utils/pin_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def _pin_memory_loop(in_queue, out_queue, device_id, done_event):
except queue.Empty:
continue
idx, data = r
if not isinstance(data, ExceptionWrapper):
if not done_event.is_set() and not isinstance(data, ExceptionWrapper):
try:
data = pin_memory(data)
except Exception:
Expand Down
6 changes: 5 additions & 1 deletion torch/utils/data/dataloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,9 +886,13 @@ def _shutdown_workers(self):
# corrupted data in `worker_result_queue` which `pin_memory_thread`
# reads from.
if hasattr(self, 'pin_memory_thread'):
self.pin_memory_thread_done_event.set()
# Use hasattr in case error happens before we set the attribute.
self.pin_memory_thread_done_event.set()
# Send something to pin_memory_thread in case it is waiting
# so that it can wake up and check `pin_memory_thread_done_event`
self.worker_result_queue.put((None, None))
self.pin_memory_thread.join()
self.worker_result_queue.close()

# Exit workers now.
self.workers_done_event.set()
Expand Down