Fix pin_memory_thread not exiting quickly #23646
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
the
module: dataloader
soumith
approved these changes
Aug 1, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
Can we have a test timinig worker shutdown (similar to example in #23642), or do you think it will be too flaky? |
Collaborator
Author
|
Yeah I thought about that but was worried it will be too flaky. Because the
“slow” shutdown time is smaller than the multiprocessing communication
timeout we allow on CI LOL.
…On Thu, Aug 1, 2019 at 12:23 ngimel ***@***.***> wrote:
Can we have a test timinig worker shutdown (similar to example in #23642
<#23642>), or do you think it
will be too flaky?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23646?email_source=notifications&email_token=ABLJMZMTLGHNT34FATCW3TLQCMEYFA5CNFSM4IINCEAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3LEM3I#issuecomment-517359213>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABLJMZLXZXW7TUFUSKAXACDQCMEYFANCNFSM4IINCEAA>
.
|
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23642