Skip to content

Remove dead Function::get_shared_ptr. #22997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ezyang wants to merge 1 commit into from
Closed

Remove dead Function::get_shared_ptr. #22997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions torch/csrc/autograd/function.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,13 +201,6 @@ struct TORCH_API Function : std::enable_shared_from_this<Function> {
return sequence_nr_;
}

/// Returns a shared pointer to `this`. `PyFunction`s are not managed by
/// `shared_ptr`s by default, but are bound to the lifetime of their Python
/// object instead.
virtual std::shared_ptr<Function> get_shared_ptr() {
return shared_from_this();
}

/// Returns the name of the dynamic type of the function, for debugging.
virtual std::string name() const;

Expand Down
4 changes: 0 additions & 4 deletions torch/csrc/autograd/python_function.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,6 @@ auto PyFunction::name() const -> std::string {
return name;
}

auto PyFunction::get_shared_ptr() -> std::shared_ptr<Function> {
return THPFunction_asFunction((THPFunction*)obj);
}

}} // namespace torch::autograd

// Traverse and clear are required for supporting Python's GC cycle handling.
Expand Down
1 change: 0 additions & 1 deletion torch/csrc/autograd/python_function.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ struct PyFunction : public Function {

void release_variables() override;
std::string name() const override;
std::shared_ptr<Function> get_shared_ptr() override;
bool is_traceable() override;

// THPFunction this Function is wrapping. Owning!
Expand Down