Added generation of transpose and dilated 2D and 3D for LongTensor #22594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: internals
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zou3519
reviewed
Jul 9, 2019
aten/src/ATen/Dispatch.h
Outdated
| } \ | ||
| }() | ||
|
|
||
| #define AT_DISPATCH_FLOATING_TYPES_AND_LONG(TYPE, NAME, ...) \ |
Contributor
There was a problem hiding this comment.
It might be nicer to add a AT_DISPATCH_FLOATING_TYPES_AND(SCALARTYPE, TYPE, NAME, ...
because there is already AT_DISPATCH_FLOATING_TYPES_AND_HALF and we might want a AT_DISPATCH_FLOATING_TYPES_AND_HALF_AND_LONG in the future...
gchanan
approved these changes
Jul 10, 2019
aten/src/ATen/Dispatch.h
Outdated
| } \ | ||
| }() | ||
|
|
||
| #define AT_DISPATCH_FLOATING_TYPES_AND_LONG(TYPE, NAME, ...) \ |
Contributor
|
Also, please fix the title/commit message. This is clearly not implementing transpose. |
ifedan
changed the title
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 17, 2019
…22594) Summary: Added implementations: transpose2D transpose3D dilated2D and dilated3D for LongTensor Pull Request resolved: pytorch/pytorch#22594 Differential Revision: D16155462 Pulled By: ifedan fbshipit-source-id: af57330314bc2c3e0a38b9e75105b20030a1f9bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added implementations: transpose2D transpose3D dilated2D and dilated3D for LongTensor