Another dce fix #22499
Closed
Another dce fix #22499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D16111969 Differential Version: 86024667
pytorchbot
added
oncall: jit
This was referenced Jul 3, 2019
Differential Revision: D16111969 Differential Version: 86025315
Contributor
|
This pull request has been merged in 2732a5e. |
xzhu1900
pushed a commit
to xzhu1900/pytorch
that referenced
this pull request
Jul 5, 2019
Summary: Pull Request resolved: pytorch#22499 Another place where onnx export is running dead code elimination after making the jit graph invalid. Fixing it. Reviewed By: houseroad Differential Revision: D16111969 fbshipit-source-id: 5ba80340c06d091988858077f142ea4e3da0638c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #22239 Open up AliasAnalysisKind for any ops 💛
:white_circle: #22175 AliasAnalysisKind::CONSERVATIVE/FROM_SCHEMA 💛
:white_circle: #22520 Don't use DeadCodeElimination from LowerAllTuples 💛
:black_circle: #22499 Another dce fix 💛
Another place where onnx export is running dead code elimination after making the jit graph invalid. Fixing it.
Differential Revision: D16111969