Skip to content

Expose is_mkldnn to python and register it as torchscript prim op #22386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bddppq wants to merge 1 commit into from
Closed

Expose is_mkldnn to python and register it as torchscript prim op #22386

bddppq wants to merge 1 commit into from

Conversation

@bddppq
Copy link
Contributor

@bddppq bddppq commented Jul 1, 2019

No description provided.

@bddppq bddppq added the module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration label Jul 1, 2019
@pytorchbot pytorchbot added oncall: jit Add this issue/PR to JIT oncall triage queue module: autograd Related to torch.autograd, and the autograd engine in general module: pybind Related to our Python bindings / interactions with other Python libraries labels Jul 1, 2019
@bddppq bddppq mentioned this pull request Jul 1, 2019
Closed
facebook-github-bot
facebook-github-bot reviewed Jul 1, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@bddppq bddppq requested a review from wanchaol July 1, 2019 17:25
@bddppq
Copy link
Contributor Author

bddppq commented Jul 1, 2019

Test failures unrelated (has been reported in #22052)

Jul 01 08:19:17 ======================================================================
Jul 01 08:19:17 ERROR: test_clip_grad_norm (__main__.TestNN)
Jul 01 08:19:17 ----------------------------------------------------------------------
Jul 01 08:19:17 Traceback (most recent call last):
Jul 01 08:19:17   File "test_nn.py", line 1829, in test_clip_grad_norm
Jul 01 08:19:17     norm = clip_grad_norm_(l.parameters(), max_norm, norm_type=norm_type)
Jul 01 08:19:17   File "/opt/conda/lib/python3.6/site-packages/torch/nn/utils/clip_grad.py", line 36, in clip_grad_norm_
Jul 01 08:19:17     clip_coef = torch.tensor(max_norm, device=device) / (total_norm + 1e-6)
Jul 01 08:19:17 UnboundLocalError: local variable 'device' referenced before assignment
Jul 01 08:19:17 
Jul 01 08:19:17 ----------------------------------------------------------------------

wanchaol
wanchaol approved these changes Jul 1, 2019
View reviewed changes
Copy link
Collaborator

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 1, 2019

@bddppq merged this pull request in d632b1f.

@bddppq bddppq deleted the py-is_mkldnn branch July 1, 2019 23:05
xzhu1900 pushed a commit to xzhu1900/pytorch that referenced this pull request Jul 5, 2019
@bddppq @xzhu1900
Expose is_mkldnn to python and register it as torchscript prim op
adf6c93 
Summary: Pull Request resolved: pytorch#22386

Differential Revision: D16074722

Pulled By: bddppq

fbshipit-source-id: b9b2a05a894847640084f063fba68d9db4e6aec1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@wanchaol wanchaol wanchaol approved these changes

Assignees

No one assigned

Labels

Merged module: autograd Related to torch.autograd, and the autograd engine in general module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration module: pybind Related to our Python bindings / interactions with other Python libraries oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bddppq @facebook-github-bot @wanchaol @pytorchbot @mruberry