[jit][redo] move casting ops from prim to aten #22275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is a redo PR of #21002 Currently we are messed up with prim and aten namespace when we register prim and builtin ops, lots of the ops that have schema should go into the aten namespace rather than prim, prim namespace should only be reserved for the ops that does not have a schema. Test Plan: Reviewers: Subscribers: Tasks: Tags:
pytorchbot
added
oncall: jit
zdevito
approved these changes
Jun 28, 2019
| _(aten, Bool) \ | ||
| _(aten, Int) \ | ||
| _(aten, Float) \ | ||
| _(aten, Str) \ |
Contributor
There was a problem hiding this comment.
Please don't capitalize, it is suppose to match Python. Note that Bool/Int/Float have to be different because they would collide with C keywords
[jit][redo] move casting ops from prim to aten Summary: This is a redo PR of #21002 Currently we are messed up with prim and aten namespace when we register prim and builtin ops, lots of the ops that have schema should go into the aten namespace rather than prim, prim namespace should only be reserved for the ops that does not have a schema. Test Plan: Reviewers: Subscribers: Tasks: Tags: gh-metadata: pytorch pytorch 22275 gh/wanchaol/27/head
…m to aten" [jit][redo] move casting ops from prim to aten Summary: This is a redo PR of #21002 Currently we are messed up with prim and aten namespace when we register prim and builtin ops, lots of the ops that have schema should go into the aten namespace rather than prim, prim namespace should only be reserved for the ops that does not have a schema. Test Plan: Reviewers: Subscribers: Tasks: Tags: gh-metadata: pytorch pytorch 22275 gh/wanchaol/27/head
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 4, 2019
Summary: Pull Request resolved: pytorch/pytorch#22275 Test Plan: Imported from OSS Differential Revision: D16060597 Pulled By: wanchaol fbshipit-source-id: a11d8ad3b037e15bd670cc7cd3fefd4f0abd0bba
Contributor
xzhu1900
pushed a commit
to xzhu1900/pytorch
that referenced
this pull request
Jul 5, 2019
Summary: Pull Request resolved: pytorch#22275 Test Plan: Imported from OSS Differential Revision: D16060597 Pulled By: wanchaol fbshipit-source-id: a11d8ad3b037e15bd670cc7cd3fefd4f0abd0bba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This is a redo PR of #21002, the previous one somehow get reverted because of a master breakage, submit it again.
Currently we are messed up with prim and aten namespace when we register prim and builtin ops, lots of the ops that have schema should go into the aten namespace rather than prim, prim namespace should only be reserved for the ops that does not have a schema.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D16060597