Skip to content

[ONNX] Add ONNX export support for multidim torch.sum. #22240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spandantiwari wants to merge 3 commits into from
Closed

[ONNX] Add ONNX export support for multidim torch.sum. #22240

spandantiwari wants to merge 3 commits into from

Conversation

@spandantiwari
Copy link

@spandantiwari spandantiwari commented Jun 25, 2019

This change fixes the issue reported in #22066.

@pytorchbot pytorchbot added the module: onnx Related to torch.onnx label Jun 25, 2019
@spandantiwari spandantiwari mentioned this pull request Jun 25, 2019
Closed
@spandantiwari spandantiwari requested a review from houseroad June 25, 2019 22:42
facebook-github-bot
facebook-github-bot reviewed Jun 25, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yf225 yf225 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 26, 2019
houseroad
houseroad reviewed Jun 26, 2019
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems more operator tests to update.

@spandantiwari
Copy link
Author

spandantiwari commented Jun 26, 2019

Seems more operator tests to update.

Thanks, I am taking a look.

facebook-github-bot
facebook-github-bot reviewed Jun 26, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@spandantiwari
Copy link
Author

spandantiwari commented Jun 26, 2019

Need to rebase and rewrite because the recent change (#22237) has changed the methods significantly.

@spandantiwari spandantiwari force-pushed the spandantiwari/reducesum_bug_fix branch from 0a109bf to d21ec06 Compare June 27, 2019 19:09
@spandantiwari
Copy link
Author

spandantiwari commented Jun 27, 2019

@houseroad - I've updated the PR to merge with the latest master. Added one more test.

facebook-github-bot
facebook-github-bot reviewed Jun 27, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad
houseroad approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@spandantiwari
Copy link
Author

spandantiwari commented Jun 27, 2019

Thanks @houseroad.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 27, 2019

@houseroad merged this pull request in 83768f0.

xzhu1900 pushed a commit to xzhu1900/pytorch that referenced this pull request Jul 5, 2019
@xzhu1900
Add ONNX export support for multidim torch.sum. (pytorch#22240)
2bb91ec 
Summary:
This change fixes the issue reported in pytorch#22066.
Pull Request resolved: pytorch#22240

Reviewed By: zrphercule

Differential Revision: D15996934

Pulled By: houseroad

fbshipit-source-id: 3a842ba26f54aa710233fbe87d727fc1f2568d9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@houseroad houseroad houseroad approved these changes

Assignees

No one assigned

Labels

Merged module: onnx Related to torch.onnx open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@spandantiwari @facebook-github-bot @houseroad @ezyang @yf225 @pytorchbot @mruberry