add setup metadata to help PyPI flesh out content on pypi package page #22085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuhdev
reviewed
Jun 25, 2019
| 'Topic :: Software Development :: Libraries :: Python Modules', | ||
| ], | ||
| license='BSD', | ||
| keywords='pytorch machine learning', |
Collaborator
There was a problem hiding this comment.
machine learning should be machine-learning perhaps? It seems that keywords are treated as space-separated list:
https://packaging.python.org/guides/distributing-packages-using-setuptools/#keywords
xuhdev
reviewed
Jun 25, 2019
setup.py
Outdated
| 'Topic :: Software Development :: Libraries', | ||
| 'Topic :: Software Development :: Libraries :: Python Modules', | ||
| ], | ||
| license='BSD', |
Collaborator
There was a problem hiding this comment.
How about BSD-3? This clarifies PyTorch is under 3-clause BSD (not 4-clause or 2-clause).
Contributor
Author
|
@pytorchbot rebase this please |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add setup metadata to help PyPI flesh out content on pypi package page.
Apparently this might help flesh out the "Used By" feature according to @driazati