Support Half type for randperm. #22046
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cuda
Collaborator
Author
|
Inspired by my closed PR #22033 |
xuhdev
force-pushed
the
randperm-type
branch
2 times, most recently
from
ff7d180 to
0120438
Compare
Collaborator
|
Build errors are to be expected, half support in thrust functions is spotty (having c10::Half define math operations helps, but not always). Frankly I don't see big problems with the way half was supported before. |
Collaborator
Author
|
@ngimel Thanks for the clarification. You are probably referring to the cuda version, but this PR also adds half for CPU version. Checks for floating point precision are also added. I can remove code changes in CUDA as you suggested. |
Collaborator
Author
|
@ngimel Updated (some cleanup stays). |
xuhdev
changed the title
xuhdev
force-pushed
the
randperm-type
branch
2 times, most recently
from
984fbfb to
cdf39cf
Compare
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously randperm supports Half type only on CUDA. This commit adds Half support for the CPU version. Precision check for floating point type is also added to ensure that integers can be properly represented.