Remove old Type based backend extensions #22009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cpp-extensions
Remove old Type based backend extensions gh-metadata: pytorch pytorch 22009 gh/li-roy/34/head
Contributor
|
looks like some tests are failing. |
gchanan
approved these changes
Jul 10, 2019
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
this looks fine, but I don't know what "Removed some tests because we shouldn't be overriding functions that don't have dispatch for backends" is supposed to mean.
added 2 commits
July 15, 2019 13:21
Remove old Type based backend extensions gh-metadata: pytorch pytorch 22009 gh/li-roy/34/head
Remove old Type based backend extensions gh-metadata: pytorch pytorch 22009 gh/li-roy/34/head
Contributor
|
is this going to be merged? |
Remove old Type based backend extensions gh-metadata: pytorch pytorch 22009 gh/li-roy/34/head
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 30, 2019
Summary: Pull Request resolved: pytorch/pytorch#22009 ghimport-source-id: e481b64707434a1abdc382fd80bd70f165540711 Test Plan: Imported from OSS Differential Revision: D15914755 Pulled By: li-roy fbshipit-source-id: 9230b8b234f71a5d865bf6bca93347c68c349ff7
Contributor
1 similar comment
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Extension backends should use ATenDispatch.h now.
Removed some tests because we shouldn't be overriding functions that don't have dispatch for backends.
Differential Revision: D15914755