Defining object destructor in c10 #21984
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure object's destructr is defined in c10 to prevent fbcode linking issues. It temporarily adds on_delete to Object so that we can dynamically get deletion to run for modules.
pytorchbot
added
oncall: jit
suo
approved these changes
Jun 19, 2019
zdevito
added a commit
to zdevito/ATen
that referenced
this pull request
Jun 20, 2019
Summary: Pull Request resolved: pytorch/pytorch#21984 ghimport-source-id: 5767592e37ed388422eed5639f8ba0722aec66e2 Test Plan: Imported from OSS Differential Revision: D15906530 Pulled By: zdevito fbshipit-source-id: bec8c8b0b5b9dcc2e8fc69b5031fcfa6bb22d54e
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This makes sure object's destructr is defined in c10 to prevent
fbcode linking issues. It temporarily adds on_delete to Object so
that we can dynamically get deletion to run for modules.
Differential Revision: D15906530