[JIT] Move NamedType method definitions into cpp file #21983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
the
module: internals
ezyang
approved these changes
Jun 19, 2019
Collaborator
Author
|
Windows build succeeded. I think we're good to go here |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 20, 2019
Summary: Pull Request resolved: pytorch/pytorch#21983 ghimport-source-id: fe9c1eba5f4c737e1442b877d396b9e8e5298cfb Test Plan: Imported from OSS Reviewed By: suo Differential Revision: D15907633 Pulled By: jamesr66a fbshipit-source-id: bd2dfdca117cdc3ae35fdd9d29cf521d82636069
Contributor
|
@jamesr66a merged this pull request in 15be548. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This may possibly fix the windows CUDA build breakage introduced by the previous PRs
Differential Revision: D15907633