Remove Type dispatch #21964
Closed
Remove Type dispatch #21964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cuda
This was referenced Jun 19, 2019
facebook-github-bot
added
the
oncall: jit
added 6 commits
June 19, 2019 10:46
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
gchanan
reviewed
Jun 21, 2019
| virtual const char * toString() const override; | ||
| virtual TypeID ID() const override; | ||
|
|
||
| struct CAFFE2_API ${Type} { |
Contributor
Author
There was a problem hiding this comment.
Going to get rid of it.
gchanan
approved these changes
Jun 21, 2019
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
looks like there's an XLA problem, but I'm guessing you are working through that already.
added 8 commits
June 21, 2019 15:27
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Closed
added 9 commits
June 24, 2019 12:54
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
gchanan
reviewed
Jun 27, 2019
| #pragma once | ||
|
|
||
| // ${generated_comment} | ||
| #include <ATen/ATen.h> |
Contributor
There was a problem hiding this comment.
why do we still need TypeDefault? Is it because you don't want to break extension mechanisms or you still want a place to have all the dispatch code? (i.e. done want to inline them in the methods or whatever?)
Contributor
Author
There was a problem hiding this comment.
All the Type classes are basically just acting as namespaces for now. TypeDefault is for the wrappers and registrations for non backend specific native functions.
gchanan
approved these changes
Jun 27, 2019
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
lgtm, I have a couple of outstanding questions.
Remove Type dispatch gh-metadata: pytorch pytorch 21964 gh/li-roy/32/head
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 30, 2019
Summary: Pull Request resolved: pytorch/pytorch#21964 ghimport-source-id: fdfb555ac4efbf31ae7d2c700a5aa44ad0cc4d7f Test Plan: Imported from OSS Differential Revision: D15897424 Pulled By: li-roy fbshipit-source-id: 3cd6744254e34d70e6875ffde749b5cf959b663c
xzhu1900
pushed a commit
to xzhu1900/pytorch
that referenced
this pull request
Jul 5, 2019
Summary: Pull Request resolved: pytorch#21964 ghimport-source-id: fdfb555 Test Plan: Imported from OSS Differential Revision: D15897424 Pulled By: li-roy fbshipit-source-id: 3cd6744254e34d70e6875ffde749b5cf959b663c
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Remove Type dispatch and related things that aren't needed anymore. The derived type classes still exist for now, but basically act just as namespaces.
Removed:
Differential Revision: D15897424