Move UnsafeTensorFromTH and UnsafeStorageFromTH off Type #21923
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: autograd
This was referenced Jun 19, 2019
Move UnsafeTensorFromTH and UnsafeStorageFromTH off Type gh-metadata: pytorch pytorch 21923 gh/li-roy/28/head
This was referenced Jun 19, 2019
Closed
added 2 commits
June 19, 2019 10:46
Move UnsafeTensorFromTH and UnsafeStorageFromTH off Type gh-metadata: pytorch pytorch 21923 gh/li-roy/28/head
Move UnsafeTensorFromTH and UnsafeStorageFromTH off Type gh-metadata: pytorch pytorch 21923 gh/li-roy/28/head
li-roy
requested review from
dzhulgakov,
ezyang,
gchanan and
smessmer
and removed request for
ezyang
gchanan
approved these changes
Jun 19, 2019
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
I'd prefer making the namespace scarier, but otherwise looks good.
|
|
||
| namespace at { | ||
|
|
||
| inline Tensor unsafeTensorFromTH(void * th_pointer, bool retain) { |
Contributor
There was a problem hiding this comment.
maybe we can just put this in at::internal or at::detail or something? I don't think anyone besides us should be calling this.
added 3 commits
June 19, 2019 22:08
Move UnsafeTensorFromTH and UnsafeStorageFromTH off Type gh-metadata: pytorch pytorch 21923 gh/li-roy/28/head
Move UnsafeTensorFromTH and UnsafeStorageFromTH off Type gh-metadata: pytorch pytorch 21923 gh/li-roy/28/head
Move UnsafeTensorFromTH and UnsafeStorageFromTH off Type gh-metadata: pytorch pytorch 21923 gh/li-roy/28/head
ezyang
approved these changes
Jun 20, 2019
added 3 commits
June 20, 2019 14:05
Move UnsafeTensorFromTH and UnsafeStorageFromTH off Type gh-metadata: pytorch pytorch 21923 gh/li-roy/28/head
Move UnsafeTensorFromTH and UnsafeStorageFromTH off Type gh-metadata: pytorch pytorch 21923 gh/li-roy/28/head
Move UnsafeTensorFromTH and UnsafeStorageFromTH off Type gh-metadata: pytorch pytorch 21923 gh/li-roy/28/head
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 21, 2019
Summary: Pull Request resolved: pytorch/pytorch#21923 ghimport-source-id: f015c8521ef9071eaa982cbf73c13aa925035956 Test Plan: Imported from OSS Differential Revision: D15883390 Pulled By: li-roy fbshipit-source-id: 6a7a7ffbe6000199d41cdca5efb97371f46dd8fe
Contributor
iotamudelta
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 21, 2019
Summary: Pull Request resolved: pytorch#21923 ghimport-source-id: f015c85 Test Plan: Imported from OSS Differential Revision: D15883390 Pulled By: li-roy fbshipit-source-id: 6a7a7ffbe6000199d41cdca5efb97371f46dd8fe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
In preparation to delete Type.
Differential Revision: D15883390