[jit] make CU::define() take only a single resolver #21920
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There isn't a use-case for making the resolvers different. The only place where we do it is stub method compilation, but they should all share a single closure environment
zdevito
approved these changes
Jun 18, 2019
[jit] make CU::define() take only a single resolver There isn't a use-case for making the resolvers different. The only place where we do it is stub method compilation, but they should all share a single closure environment gh-metadata: pytorch pytorch 21920 gh/suo/65/head
Member
Author
|
Turns out this is annoying while weak_script still exists. Setting aside for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
There isn't a use-case for making the resolvers different. The only
place where we do it is stub method compilation, but they should all
share a single closure environment
Differential Revision: D15882059