Skip to content

[JIT] Fix WeakIValueEq #21891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamesr66a wants to merge 1 commit into from
Closed

[JIT] Fix WeakIValueEq #21891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions aten/src/ATen/core/ivalue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,11 @@ struct CAFFE2_API WeakIValue final {
std::swap(tag, rhs.tag);
}

bool isSameIdentity(const WeakIValue& rhs) const {
return payload.as_int == rhs.payload.as_int && tag == rhs.tag &&
is_intrusive_ptr == rhs.is_intrusive_ptr;
}

IValue lock() const {
if (!is_intrusive_ptr) {
return IValue(payload, tag, false);
Expand Down
2 changes: 1 addition & 1 deletion torch/csrc/jit/tracer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ struct TORCH_API TracingState

struct WeakIValueEq {
bool operator()(const WeakIValue& t1, const WeakIValue& t2) const {
return t1.lock().isSameIdentity(t2.lock());
return t1.isSameIdentity(t2);
}
};

Expand Down