[jit] fix bug in CompilationUnit::define #21886
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were re-ordering definitions to put `__init__` first, but not reordering resolvers. In reality, resolvers are always the same so this doesn't matter. I may make `define()` take a single resolver in a future PR. Either way, this change is good because it avoids a copy of the whole AST during `define()` as well.
zdevito
approved these changes
Jun 18, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
NGNT. Definitely want to see us merge resolver into a single argument. They are all the same and managing them is annoying.
[jit] fix bug in CompilationUnit::define We were re-ordering definitions to put `__init__` first, but not reordering resolvers. In reality, resolvers are always the same so this doesn't matter. I may make `define()` take a single resolver in a future PR. Either way, this change is good because it avoids a copy of the whole AST during `define()` as well. gh-metadata: pytorch pytorch 21886 gh/suo/64/head
[jit] fix bug in CompilationUnit::define We were re-ordering definitions to put `__init__` first, but not reordering resolvers. In reality, resolvers are always the same so this doesn't matter. I may make `define()` take a single resolver in a future PR. Either way, this change is good because it avoids a copy of the whole AST during `define()` as well. gh-metadata: pytorch pytorch 21886 gh/suo/64/head
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We were re-ordering definitions to put
__init__first, but notreordering resolvers. In reality, resolvers are always the same so this
doesn't matter. I may make
define()take a single resolver in a futurePR.
Either way, this change is good because it avoids a copy of the whole
AST during
define()as well.Differential Revision: D15867647