Skip to content

[JIT] Some small fixes for NamedTuple #21813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jamesr66a wants to merge 6 commits into from
Closed

[JIT] Some small fixes for NamedTuple #21813

jamesr66a wants to merge 6 commits into from

Conversation

@jamesr66a
Copy link
Collaborator

@jamesr66a jamesr66a commented Jun 15, 2019 •
edited
Loading

Stack from ghstack:

I realized two things:

  1. There's an unnecessary ErrorReport if a NamedTuple constructor is called with kwargs. Removed it
  2. We don't actually support the default values for fields, so we now throw an error if a NamedTuple definition has them.

Differential Revision: D15860005

@jamesr66a jamesr66a mentioned this pull request Jun 15, 2019
Closed
@pytorchbot pytorchbot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 15, 2019
Update on "[JIT] Some small fixes for NamedTuple"
0e1fb4e 
[JIT] Some small fixes for NamedTuple

gh-metadata: pytorch pytorch 21813 gh/jamesr66a/2/head
@jamesr66a jamesr66a requested review from suo and zdevito and removed request for suo June 15, 2019 01:58
This was referenced Jun 16, 2019
Closed
Closed
Closed
Update on "[JIT] Some small fixes for NamedTuple"
af368a5 
[JIT] Some small fixes for NamedTuple

gh-metadata: pytorch pytorch 21813 gh/jamesr66a/2/head
@jamesr66a jamesr66a mentioned this pull request Jun 16, 2019
Closed
zdevito
zdevito approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@zdevito zdevito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.6 roentgen. not great. not terrible. should be good to go once it doesn't catch std::exception.

James Reed added 3 commits June 17, 2019 10:49
Update on "[JIT] Some small fixes for NamedTuple"
38590e8 
[JIT] Some small fixes for NamedTuple

gh-metadata: pytorch pytorch 21813 gh/jamesr66a/2/head
Update on "[JIT] Some small fixes for NamedTuple"
b6f2972 
[JIT] Some small fixes for NamedTuple

gh-metadata: pytorch pytorch 21813 gh/jamesr66a/2/head
Update on "[JIT] Some small fixes for NamedTuple"
d730a4a 
[JIT] Some small fixes for NamedTuple

gh-metadata: pytorch pytorch 21813 gh/jamesr66a/2/head
@zou3519 zou3519 deleted the gh/jamesr66a/2/head branch June 19, 2019 17:46
@jamesr66a jamesr66a mentioned this pull request Jun 19, 2019
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 19, 2019

@jamesr66a merged this pull request in 74104f3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zdevito zdevito zdevito approved these changes

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jamesr66a @facebook-github-bot @zdevito @pytorchbot @mruberry