Skip to content

[JIT] Fix slow unpickling #21542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamesr66a wants to merge 1 commit into from
Closed

[JIT] Fix slow unpickling #21542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions torch/csrc/jit/pickler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ OpCode Unpickler::readInstruction() {
} break;
case OpCode::BINPUT: {
size_t memo_id = read<uint8_t>();
if (memo_table_.size() <= memo_id) {
if (memo_table_.capacity() <= memo_id) {
memo_table_.reserve(1 + 2 * memo_id);
}
memo_table_.push_back(stack_.back());
Expand All @@ -612,7 +612,7 @@ OpCode Unpickler::readInstruction() {
"Found a LONG_BINPUT opcode, but size_t on this system is "
"not big enough to decode it");
size_t memo_id = read<uint32_t>();
if (memo_table_.size() <= memo_id) {
if (memo_table_.capacity() <= memo_id) {
memo_table_.reserve(1 + 2 * memo_id);
}
memo_table_.push_back(stack_.back());
Expand Down