Skip to content

[JIT] fix incorrect default on Graph::toString #21370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamesr66a wants to merge 1 commit into from
Closed

[JIT] fix incorrect default on Graph::toString #21370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions test/test_jit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3705,8 +3705,9 @@ def foobar(xyz):
scripted = torch.jit.script(foobar)

_, lineno = inspect.getsourcelines(foobar)
FileCheck().check('test_jit.py:{}:20'.format(lineno + 1))\
.run(scripted.graph)
fc = FileCheck().check('test_jit.py:{}:20'.format(lineno + 1))
fc.run(scripted.graph)
fc.run(str(scripted.graph))

def test_file_line_save_load(self):
class Scripted(torch.jit.ScriptModule):
Expand All @@ -3723,15 +3724,19 @@ def forward(self, xyz):
bytesio = io.BytesIO(buffer)
scripted = torch.jit.load(bytesio)

FileCheck().check('code/archive.py:4:10').run(scripted.graph)
fc = FileCheck().check('code/archive.py:4:10')
fc.run(scripted.graph)
fc.run(str(scripted.graph))

def test_file_line_string(self):
scripted = torch.jit.CompilationUnit('''
def foo(xyz):
return torch.neg(xyz)
''')

FileCheck().check('<string>:2:12').run(scripted.foo.graph)
fc = FileCheck().check('<string>:2:12')
fc.run(scripted.foo.graph)
fc.run(str(scripted.foo.graph))

def test_file_line_trace(self):
def foobar(xyz):
Expand All @@ -3740,8 +3745,9 @@ def foobar(xyz):
scripted = torch.jit.trace(foobar, (torch.rand(3, 4)))

_, lineno = inspect.getsourcelines(foobar)
FileCheck().check('test_jit.py:{}:0'.format(lineno + 1))\
.run(scripted.graph)
fc = FileCheck().check('test_jit.py:{}:0'.format(lineno + 1))
fc.run(scripted.graph)
fc.run(str(scripted.graph))

def test_tensor_shape(self):
x = torch.empty(34, 56, 78)
Expand Down
2 changes: 1 addition & 1 deletion torch/csrc/jit/ir.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,7 +1176,7 @@ struct Graph {

TORCH_API ~Graph();

TORCH_API std::string toString(bool print_source_locations=false) const;
TORCH_API std::string toString(bool print_source_locations = true) const;

TORCH_API std::ostream& print(
std::ostream& out,
Expand Down