Skip to content

Revert custom strtod implementation #21369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smessmer wants to merge 2 commits into from
Closed

Revert custom strtod implementation #21369

smessmer wants to merge 2 commits into from

Conversation

@smessmer
Copy link
Contributor

@smessmer smessmer commented Jun 4, 2019 •
edited
Loading

Stack:
    :black_circle:  #21369 Revert custom strtod implementation  💛

We wrote a custom strtod implementation because strtod_c isn't available on Android.
Since that code is not used on Android, we can actually revert to the much simpler implementation.

This hopefully fixes this issue: #20804

Differential Revision: D15630245

@smessmer
V1: Initial commit
49fc6de 
Differential Revision: D15630245
Differential Version: 84237861
@pytorchbot pytorchbot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 4, 2019
@smessmer smessmer mentioned this pull request Jun 4, 2019
Closed
@bddppq
Copy link
Contributor

bddppq commented Jun 4, 2019

btw. we have also run into a gcc abi version issue with the custom strtod implementation #21293

@bddppq
Copy link
Contributor

bddppq commented Jun 4, 2019

Looks like android build is actually using it though:
https://circleci.com/api/v1.1/project/github/pytorch/pytorch/1913500/output/106/0?file=true

Jun 04 20:05:03 [ 46%] Building CXX object caffe2/CMakeFiles/caffe2.dir/__/torch/csrc/jit/script/strtod.cpp.o
Jun 04 20:05:03 /var/lib/jenkins/workspace/torch/csrc/jit/script/strtod.cpp: In function 'double torch::jit::script::strtod_c(const char*, char**)':
Jun 04 20:05:03 /var/lib/jenkins/workspace/torch/csrc/jit/script/strtod.cpp:28:34: error: 'strtod_l' was not declared in this scope
Jun 04 20:05:03      return strtod_l(str, end, loc);

@smessmer
V2: (no description)
db245f7 
Differential Revision: D15630245
Differential Version: 84271673
ezyang
ezyang requested changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lexer uses it too...

@ezyang ezyang added facebook and removed facebook labels Jun 5, 2019
@smessmer
Copy link
Contributor Author

smessmer commented Jun 6, 2019

abandoning in favor of #21293

@smessmer smessmer closed this Jun 6, 2019
@ezyang ezyang deleted the export-D15630245 branch July 19, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang requested changes

Assignees

No one assigned

Labels

oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smessmer @bddppq @ezyang @pytorchbot