Skip to content

[JIT] Exclude file:line from graphs used for fuser kernel cache #21252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jamesr66a wants to merge 1 commit into from
Closed

[JIT] Exclude file:line from graphs used for fuser kernel cache #21252

jamesr66a wants to merge 1 commit into from

Conversation

@jamesr66a
Copy link
Collaborator

@jamesr66a jamesr66a commented Jun 1, 2019

cc @ezyang this is meant to fix the fuser failures on master

@jamesr66a jamesr66a requested review from ezyang, suo and zdevito June 1, 2019 18:38
@pytorchbot pytorchbot added oncall: jit Add this issue/PR to JIT oncall triage queue module: pybind Related to our Python bindings / interactions with other Python libraries labels Jun 1, 2019
@jamesr66a
Copy link
Collaborator Author

jamesr66a commented Jun 1, 2019

@pytorchbot retest this please

@jamesr66a
Copy link
Collaborator Author

jamesr66a commented Jun 1, 2019

@pytorchbot rebase this please

@pytorchbot
Copy link
Collaborator

pytorchbot commented Jun 1, 2019

Sorry, I can't merge this because there are conflicts. To merge this yourself, run the commands below:

git fetch origin master
git fetch git@github.com:jamesr66a/pytorch.git fix_kernel_cache
git checkout FETCH_HEAD
git merge origin/master
git push git@github.com:jamesr66a/pytorch.git HEAD:fix_kernel_cache

(To learn more about this bot, see Bot commands.)

facebook-github-bot
facebook-github-bot reviewed Jun 1, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesr66a is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 1, 2019

@jamesr66a merged this pull request in 62ae348.

@ezyang
Copy link
Contributor

ezyang commented Jun 2, 2019

Fix doesn't seem sufficient; this test which also failed at the same time on master is still failing:

Jun 02 00:17:55 ======================================================================
Jun 02 00:17:55 ERROR: test_data_parallel_rnn (__main__.TestNN)
Jun 02 00:17:55 ----------------------------------------------------------------------
Jun 02 00:17:55 Traceback (most recent call last):
Jun 02 00:17:55   File "/var/lib/jenkins/workspace/test/common_utils.py", line 149, in wrapper
Jun 02 00:17:55     fn(*args, **kwargs)
Jun 02 00:17:55   File "test_nn.py", line 3872, in test_data_parallel_rnn
Jun 02 00:17:55     model = Model().to(0)
Jun 02 00:17:55   File "test_nn.py", line 3856, in __init__
Jun 02 00:17:55     super().__init__()
Jun 02 00:17:55 TypeError: super() takes at least 1 argument (0 given)
Jun 02 00:17:55

@jamesr66a
Copy link
Collaborator Author

jamesr66a commented Jun 2, 2019

@ezyang that looks unrelated to my prior change, since it doesn't involve the JIT at all

@jamesr66a
Copy link
Collaborator Author

jamesr66a commented Jun 2, 2019

@mrshenli it looks like #21197 introduced the breakage that @ezyang pointed out above

@mrshenli
Copy link
Contributor

mrshenli commented Jun 2, 2019

@jamesr66a @ezyang thanks for the catch. I am working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@suo suo suo approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@zdevito zdevito Awaiting requested review from zdevito

Assignees

No one assigned

Labels

Merged module: pybind Related to our Python bindings / interactions with other Python libraries oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jamesr66a @pytorchbot @facebook-github-bot @ezyang @mrshenli @suo @mruberry