Skip to content

Finished trigonometric functions #21128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Chillee wants to merge 22 commits into from
Closed

Finished trigonometric functions #21128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
99ccc2f
Finished trigonometric functions
Chillee May 30, 2019
a586b73
Update on "Finished trigonometric functions"
Chillee May 30, 2019
964b4a4
Update on "Finished trigonometric functions"
Chillee May 30, 2019
1cfddaf
Update on "Finished trigonometric functions"
Chillee May 30, 2019
10dafdb
Update on "Finished trigonometric functions"
Chillee May 30, 2019
d4ac001
Update on "Finished trigonometric functions"
Chillee May 30, 2019
314d745
Update on "Finished trigonometric functions"
Chillee May 30, 2019
a61236b
Update on "Finished trigonometric functions"
Chillee May 30, 2019
53d3810
Update on "Finished trigonometric functions"
Chillee May 31, 2019
065424e
Update on "Finished trigonometric functions"
Chillee May 31, 2019
27dd743
Update on "Finished trigonometric functions"
Chillee May 31, 2019
53d5ad5
Update on "Finished trigonometric functions"
Chillee May 31, 2019
099c894
Update on "Finished trigonometric functions"
Chillee May 31, 2019
962230c
Update on "Finished trigonometric functions"
Chillee May 31, 2019
0f03167
Update on "Finished trigonometric functions"
Chillee May 31, 2019
0f3e359
Update on "Finished trigonometric functions"
Chillee Jun 3, 2019
6e7d70e
Update on "Finished trigonometric functions"
Chillee Jun 3, 2019
2464a7a
Update on "Finished trigonometric functions"
Chillee Jun 3, 2019
b81a27c
Update on "Finished trigonometric functions"
Chillee Jun 3, 2019
b0e3f66
Update on "Finished trigonometric functions"
Chillee Jun 3, 2019
29b3525
Update on "Finished trigonometric functions"
Chillee Jun 4, 2019
70277fa
Update on "Finished trigonometric functions"
Chillee Jun 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/test_jit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6120,9 +6120,9 @@ def func(a, b):
.format(func_name=func_name, a=a, b=b, res_python=res_python, res_script=res_script))
self.assertEqual(res_python, res_script, message=msg, prec=(1e-4) * max(abs(res_python), res_script))


unary_float_ops = ["log", "log1p", "log10", "exp", "sqrt", "gamma", "lgamma", "erf",
"erfc", "expm1", "fabs", "acos", "asin", "atan", "cos", "sin", "tan"]
"erfc", "expm1", "fabs", "acos", "asin", "atan", "cos", "sin", "tan",
"asinh", "atanh", "acosh", "sinh", "cosh", "tanh"]
binary_float_ops = ["atan2", "fmod", "copysign"]
for op in unary_float_ops:
checkMathWrap(op)
Expand Down
6 changes: 6 additions & 0 deletions torch/csrc/jit/register_prim_ops.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2160,6 +2160,12 @@ RegisterOperators reg2({
DEFINE_UNARY_OP(aten::cos, std::cos(a), float, float),
DEFINE_UNARY_OP(aten::sin, std::sin(a), float, float),
DEFINE_UNARY_OP(aten::tan, std::tan(a), float, float),
DEFINE_UNARY_OP(aten::asinh, std::asinh(a), float, float),
DEFINE_UNARY_OP(aten::atanh, std::atanh(a), float, float),
DEFINE_UNARY_OP(aten::acosh, std::acosh(a), float, float),
DEFINE_UNARY_OP(aten::sinh, std::sinh(a), float, float),
DEFINE_UNARY_OP(aten::cosh, std::cosh(a), float, float),
DEFINE_UNARY_OP(aten::tanh, std::tanh(a), float, float),
DEFINE_BINARY_FLOAT_OP(aten::fmod, std::fmod(a, b)),
Operator(
"aten::modf(float a) -> (float, float)",
Expand Down
6 changes: 6 additions & 0 deletions torch/jit/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1900,6 +1900,12 @@ def register_all(mod):
(math.cos, "aten::cos"),
(math.sin, "aten::sin"),
(math.tan, "aten::tan"),
(math.asinh, "aten::asinh"),
(math.atanh, "aten::atanh"),
(math.acosh, "aten::acosh"),
(math.sinh, "aten::sinh"),
(math.cosh, "aten::cosh"),
(math.tanh, "aten::tanh"),
(math.fmod, "aten::fmod"),
(math.modf, "aten::modf"),
(torch._C._infer_size, "aten::_infer_size"),
Expand Down