Conservative alias analysis rules for CallFunction/CallMethod #21087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Uses the analyzeCustomOp rule (renamed analyzeConservative) to support CallFunction, assuming we do not know the function implementation. When we have a know function target, and a way to summarize alias info we can make the analysis more accurate. Cleans up seemingly dead code in alias analysis and fixes a bug in analyzeCustomOp where inputs are not marked as potentially aliasing the wildcard set. Test Plan: test_jit.py
pytorchbot
added
oncall: jit
suo
approved these changes
May 29, 2019
…hod" Conservative alias analysis rules for CallFunction/CallMethod Summary: Uses the analyzeCustomOp rule (renamed analyzeConservative) to support CallFunction, assuming we do not know the function implementation. When we have a know function target, and a way to summarize alias info we can make the analysis more accurate. Cleans up seemingly dead code in alias analysis and fixes a bug in analyzeCustomOp where inputs are not marked as potentially aliasing the wildcard set. Test Plan: test_jit.py gh-metadata: pytorch pytorch 21087 gh/zdevito/41/head
…hod" Conservative alias analysis rules for CallFunction/CallMethod Summary: Uses the analyzeCustomOp rule (renamed analyzeConservative) to support CallFunction, assuming we do not know the function implementation. When we have a know function target, and a way to summarize alias info we can make the analysis more accurate. Cleans up seemingly dead code in alias analysis and fixes a bug in analyzeCustomOp where inputs are not marked as potentially aliasing the wildcard set. Test Plan: test_jit.py gh-metadata: pytorch pytorch 21087 gh/zdevito/41/head
…hod" Conservative alias analysis rules for CallFunction/CallMethod Summary: Uses the analyzeCustomOp rule (renamed analyzeConservative) to support CallFunction, assuming we do not know the function implementation. When we have a know function target, and a way to summarize alias info we can make the analysis more accurate. Cleans up seemingly dead code in alias analysis and fixes a bug in analyzeCustomOp where inputs are not marked as potentially aliasing the wildcard set. Test Plan: test_jit.py gh-metadata: pytorch pytorch 21087 gh/zdevito/41/head
zdevito
added a commit
to zdevito/ATen
that referenced
this pull request
May 30, 2019
Summary: Pull Request resolved: pytorch/pytorch#21087 ghimport-source-id: 4fa6763ffecc7d2974b902dd9bd2bd9ac467bab7 Differential Revision: D15542512 Pulled By: zdevito fbshipit-source-id: 2dcd673cd4c200d7a854347429d4f33a11793cbc
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: Uses the analyzeCustomOp rule (renamed analyzeConservative)
to support CallFunction, assuming we do not know the function implementation.
When we have a know function target, and a way to summarize alias info
we can make the analysis more accurate.
Cleans up seemingly dead code in alias analysis and fixes a bug in
analyzeCustomOp where inputs are not marked as potentially aliasing the
wildcard set.
Test Plan: test_jit.py
Differential Revision: D15542512