First class functions in IR, inlined eagerly #21052
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is a continuation of #18367 that rebases it and cleans up some of the issues that were popping up. Notes: 1. removed special handling for Python 2 print statements. Its implementation was buggy (treated inlined tuples as literal tuples), and leaving it out just means that in Python 2 printing multiple values will print different in script and python. This is ok, because it is minor formatting differences and only in Python 2. 2. --accepted internal loss of ONNX type information. We are only required to have correct input and output types for ONNX not for intermediates.
pytorchbot
added
caffe2
oncall: jit
First class functions in IR, inlined eagerly Summary: This is a continuation of #18367 that rebases it and cleans up some of the issues that were popping up. Notes: 1. removed special handling for Python 2 print statements. Its implementation was buggy (treated inlined tuples as literal tuples), and leaving it out just means that in Python 2 printing multiple values will print different in script and python. This is ok, because it is minor formatting differences and only in Python 2. 2. --accepted internal loss of ONNX type information. We are only required to have correct input and output types for ONNX not for intermediates. gh-metadata: pytorch pytorch 21052 gh/zdevito/40/head
First class functions in IR, inlined eagerly Summary: This is a continuation of #18367 that rebases it and cleans up some of the issues that were popping up. Notes: 1. removed special handling for Python 2 print statements. Its implementation was buggy (treated inlined tuples as literal tuples), and leaving it out just means that in Python 2 printing multiple values will print different in script and python. This is ok, because it is minor formatting differences and only in Python 2. 2. --accepted internal loss of ONNX type information. We are only required to have correct input and output types for ONNX not for intermediates. gh-metadata: pytorch pytorch 21052 gh/zdevito/40/head
First class functions in IR, inlined eagerly Summary: This is a continuation of #18367 that rebases it and cleans up some of the issues that were popping up. Notes: 1. removed special handling for Python 2 print statements. Its implementation was buggy (treated inlined tuples as literal tuples), and leaving it out just means that in Python 2 printing multiple values will print different in script and python. This is ok, because it is minor formatting differences and only in Python 2. 2. --accepted internal loss of ONNX type information. We are only required to have correct input and output types for ONNX not for intermediates. gh-metadata: pytorch pytorch 21052 gh/zdevito/40/head
First class functions in IR, inlined eagerly Summary: This is a continuation of #18367 that rebases it and cleans up some of the issues that were popping up. Notes: 1. removed special handling for Python 2 print statements. Its implementation was buggy (treated inlined tuples as literal tuples), and leaving it out just means that in Python 2 printing multiple values will print different in script and python. This is ok, because it is minor formatting differences and only in Python 2. 2. --accepted internal loss of ONNX type information. We are only required to have correct input and output types for ONNX not for intermediates. gh-metadata: pytorch pytorch 21052 gh/zdevito/40/head stuff
First class functions in IR, inlined eagerly Summary: This is a continuation of #18367 that rebases it and cleans up some of the issues that were popping up. Notes: 1. removed special handling for Python 2 print statements. Its implementation was buggy (treated inlined tuples as literal tuples), and leaving it out just means that in Python 2 printing multiple values will print different in script and python. This is ok, because it is minor formatting differences and only in Python 2. 2. --accepted internal loss of ONNX type information. We are only required to have correct input and output types for ONNX not for intermediates. gh-metadata: pytorch pytorch 21052 gh/zdevito/40/head stuff no
First class functions in IR, inlined eagerly Summary: This is a continuation of #18367 that rebases it and cleans up some of the issues that were popping up. Notes: 1. removed special handling for Python 2 print statements. Its implementation was buggy (treated inlined tuples as literal tuples), and leaving it out just means that in Python 2 printing multiple values will print different in script and python. This is ok, because it is minor formatting differences and only in Python 2. 2. --accepted internal loss of ONNX type information. We are only required to have correct input and output types for ONNX not for intermediates. gh-metadata: pytorch pytorch 21052 gh/zdevito/40/head stuff no
zdevito
added a commit
to zdevito/ATen
that referenced
this pull request
May 30, 2019
Summary: Pull Request resolved: pytorch/pytorch#21052 ghimport-source-id: cc476b9cc301967dde5de6212ca144cdb252e84c Differential Revision: D15533353 Pulled By: zdevito fbshipit-source-id: 4d25461969cfcc9e5f641d585584cc100c7b34ae
Contributor
1 similar comment
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: This is a continuation of #18367 that rebases it and cleans up
some of the issues that were popping up.
Notes:
removed special handling for Python 2 print statements. Its
implementation was buggy (treated inlined tuples as literal tuples),
and leaving it out just means that in Python 2 printing multiple values
will print different in script and python. This is ok, because it is
minor formatting differences and only in Python 2.
--accepted internal loss of ONNX type information. We are only
required to have correct input and output types for ONNX not for
intermediates.
Differential Revision: D15533353