[jit] refactor register_prim_ops #21001
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2019
driazati
approved these changes
May 28, 2019
Contributor
driazati
left a comment
driazati
left a comment
There was a problem hiding this comment.
Seems fine, though it's all temporary until we land something along the lines of #19373, bind all these as custom ops, and delete all these macros.
#19373 was blocked on removing assumptions that prim:: and aten:: ops are pure unless annotated otherwise (they should match custom ops, which are assumed to be side-effectful unless specified)
Member
|
@driazati the purity thing is fixed btw so that PR is no longer blocked |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D15523445