Skip to content

fix the bug for mkldnn clone #20943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XiaobingSuper wants to merge 2 commits into from
Closed

fix the bug for mkldnn clone #20943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9551600
fix the bug for mkldnn clone
XiaobingSuper May 25, 2019
02a6761
add test case to check mkldnn clone not share same memory
XiaobingSuper May 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion aten/src/ATen/native/mkldnn/TensorShape.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ Tensor mkldnn_reshape(const Tensor& self, IntArrayRef size) {

Tensor mkldnn_clone(const Tensor& self) {
ideep::tensor& src = itensor_from_mkldnn(self);
ideep::tensor dst{src};
ideep::tensor dst;
ideep::direct_copy::compute<AllocForMKLDNN>(src, dst);
return new_with_itensor_mkldnn(std::move(dst), self.options());
}

Expand Down
7 changes: 7 additions & 0 deletions test/test_mkldnn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,13 @@ def test_clone(self):
x.clone(),
x.to_mkldnn().clone().to_dense(),
)
# test whether share same memory
y = x.to_mkldnn()
z = y.clone().add_(y)
self.assertNotEqual(
y.to_dense(),
z.to_dense(),
)

def test_linear(self):
in_features = torch.randint(3, 10, (1,)).item()
Expand Down