Skip to content

Conversation

@jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented May 3, 2019

Stack:
    :white_circle:  #20656 [pt1][quant] int_repr for different quantized types  💛
    :black_circle:  #20107 [pt1][quant] Add dequantize_linear for JIT pass  💚

att

Differential Revision: D15202187

Differential Revision: D15094174
Differential Version: 80838655
Differential Revision: D15094174
Differential Version: 80839141
Differential Revision: D15094174
Differential Version: 80909406
Differential Revision: D15094174
Differential Version: 80918409
Differential Revision: D15137838
Differential Version: 80919404
Differential Revision: D15137838
Differential Version: 80940601
Differential Revision: D15094174
Differential Version: 80977784
Differential Revision: D15094174
Differential Version: 80996728
Differential Revision: D15137838
Differential Version: 80996800
Differential Revision: D15150715
Differential Version: 80996764
Differential Revision: D15094174
Differential Version: 81007920
Differential Revision: D15094174
Differential Version: 81099685
Differential Revision: D15137838
Differential Version: 81109398
Differential Revision: D15150715
Differential Version: 81113084
Differential Revision: D15202187
Differential Version: 81167463
jerryzh168 added 9 commits May 3, 2019 12:11
Differential Revision: D15094174
Differential Version: 81173037
Differential Revision: D15094174
Differential Version: 81239113
Differential Revision: D15094174
Differential Version: 81253515
Differential Revision: D15094174
Differential Version: 81263921
Differential Revision: D15202187
Differential Version: 81281334
Differential Revision: D15094174
Differential Version: 81319070
Differential Revision: D15094174
Differential Version: 81328044
Differential Revision: D15094174
Differential Version: 81380836
Differential Revision: D15094174
Differential Version: 81411153
Differential Revision: D15137838
Differential Version: 81699511
Differential Revision: D15150715
Differential Version: 81699751
@nishantpdce
Copy link
Contributor

Please run clang-format on the .h/.cpp files

jerryzh168 and others added 6 commits May 14, 2019 17:46
Differential Revision: D15202187
Differential Version: 81740423
Differential Revision: D15137838
Differential Version: 82009220
Differential Revision: D15150715
Differential Version: 82024560
Differential Revision: D15202187
Differential Version: 82030992
Differential Revision: D15150715
Differential Version: 82077846
Differential Revision: D15150715
Differential Version: 82142681
Differential Revision: D15202187
Differential Version: 82189466
Differential Revision: D15202187
Differential Version: 82409133
@jerryzh168 jerryzh168 changed the base branch from export-D15150715 to master May 20, 2019 20:43
Differential Revision: D15202187
Differential Version: 82456360
@pytorchbot pytorchbot added the module: docs Related to our documentation, both in docs/ and docblocks label May 20, 2019
Differential Revision: D15202187
Differential Version: 82477545
@dzhulgakov
Copy link
Collaborator

dumb question - why do you need this if you have as_quantized_tensor in the following diff? also, how is it going to be used in the JIT pass, just curious?

@jerryzh168
Copy link
Contributor Author

jerryzh168 commented May 21, 2019

@dzhulgakov in JIT pass, we want explicit scale, zero_point argument in dequantize so that we don't need to traverse back to find these argument in quantize_linear. We don't expect this function to be used by user, this is for JIT pass only.

Differential Revision: D15202187
Differential Version: 82551619
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in cca923c.

zdevito pushed a commit to zdevito/ATen that referenced this pull request May 21, 2019
Summary:
Pull Request resolved: pytorch/pytorch#20107

att

Reviewed By: nishantpdce

Differential Revision: D15202187

fbshipit-source-id: 7d6274a67fcca695c0425587f35046fecbc2ccdc
@ezyang ezyang deleted the export-D15202187 branch May 30, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: docs Related to our documentation, both in docs/ and docblocks module: internals Related to internal abstractions in c10 and ATen oncall: quantization Quantization support in PyTorch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants