Sparse Half Embedding backward/sum on cpu #20061
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds minimal support for sparse half embedding on CPU (backward() and sum()). Previous PR only allowed sum().backward() of sparse half embedding on CUDA. We can add more operators if this is useful, but currently skips most CPU operator implementations that depend on blas or vec256 since they don't have float16 support.
After 19695,
Gave:
RuntimeError: _th_index_select not supported on CPUType for Halfand
a(torch.LongTensor([1, 0]).sum()gave an error that sum_cpu was not available.Builds on: #19695
Don't need to re-review commits before 29a72ea