Support sparse gradients in DistributedDataParallel #19443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D15007365 Differential Version: 80026012
pietern
added
oncall: distributed
mrshenli
reviewed
Apr 22, 2019
Contributor
mrshenli
left a comment
mrshenli
left a comment
There was a problem hiding this comment.
Shall we add some tests?
This was referenced Apr 23, 2019
Differential Revision: D15007365 Differential Version: 85199090
Differential Revision: D15007365 Differential Version: 85203697
Differential Revision: D15007365 Differential Version: 85204462
Contributor
Author
|
@mrshenli Added a test case that confirms numerical equivalence between unwrapped and wrapped module. |
mrshenli
approved these changes
Jun 19, 2019
Contributor
Author
|
@pytorchbot retest this please |
Contributor
|
This pull request has been merged in 365de7b. |
Contributor
|
This diff stack broke ~all tests on master. Sample failure: https://circleci.com/gh/pytorch/pytorch/2038576?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link/console |
|
hello, I wonder if the modification is effective in these .whl files ? torch_download |
|
I got torch by |
|
I cannot set sparse=True in nn.Embedding under ddp on 1.9.1+cu102, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #19443 Support sparse gradients in DistributedDataParallel 💛
:white_circle: #19146 Add sparse tensor allreduce 💛
This adds support for sparse gradients to the reducer as well as to
the DistributedDataParallel wrapper. Note that an out of band signal
is needed whether or not a dense parameter (e.g. an embedding) is
expected to receive a sparse gradient or not. This information is
passed to the bucket assignment computation routine and the reducer as
a vector of booleans. Every parameter for which we expect a sparse
gradient is assigned its own bucket, as we cannot easily group
multiple unrelated sparse tensors.
Differential Revision: D15007365