[wip][jit] Refactor math ops to use custom op bindings #19373
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
added 2 commits
April 17, 2019 15:06
[jit] Refactor math ops to use custom op bindings gh-metadata: pytorch pytorch 19373 gh/driazati/13/head
[jit] Refactor math ops to use custom op bindings gh-metadata: pytorch pytorch 19373 gh/driazati/13/head
eellison
reviewed
Apr 17, 2019
|
|
||
| auto schema = torch::jit::detail::inferAndCheckSchema<Traits>(schemaOrName); | ||
|
|
||
| // [custom operator aliasing] Currently, we have no way for the user to |
Contributor
There was a problem hiding this comment.
Why did you delete this ?
Member
There was a problem hiding this comment.
I think we should do this clean up in a separate PR where you track down all references to this note and fix those up as well. Don't leave the pointers dangling!
[jit] Refactor math ops to use custom op bindings gh-metadata: pytorch pytorch 19373 gh/driazati/13/head
driazati
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D14987159
Now that we have a way to specify basic aliasing behavior for custom ops, we can register math ops as custom ops (and hopefully more things in register_prim_ops). Due to this we don't need to manually whitelistatenandprimfor alias anaylsis, so the restriction when binding custom ops can be deleted.TODO: right now aten ops are assumed to be pure and custom ops are assumed to be side effectful. we should merge these so everything is assumed to be side effectful unless stated otherwise