Fix transpose axes for pixel_shuffle conversion #19054
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When converting pixel_shuffle to reshape + transpose, the transpose should be: [-1, upscale_factor, upscale_factor, output_channel, dims[2], dims[3]] => [-1, dims[2], upscale_factor, dims[3], upscale_factor, output_channel] We want to vary the spatial dimensions slower than the upscale dim, otherwise we get tiling instead of upscaling. Differential Revision: D14817912 fbshipit-source-id: 112ddf50d8ce22db39542e9202214050fadc4e57
Member
Contributor
Author
|
Actual fix in #21486 (issue was in the previous reshape, not the transpose). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When converting pixel_shuffle to reshape + transpose, the transpose should be:
[-1, upscale_factor, upscale_factor, output_channel, dims[2], dims[3]]
=>
[-1, dims[2], upscale_factor, dims[3], upscale_factor, output_channel]
We want to vary the spatial dimensions slower than the upscale dim, otherwise
we get tiling instead of upscaling.
Differential Revision: D14817912