update doc for multinomial #17269
Closed
update doc for multinomial #17269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssnl
reviewed
Feb 19, 2019
| :attr:`input` length (or number of columns of :attr:`input` if it is a matrix). | ||
| .. note:: | ||
| When drawn without replacement, :attr:`num_samples` must be lower than | ||
| number of non-zero elements in :attr:`input` (or the min number of non-zero |
Collaborator
There was a problem hiding this comment.
The example below is still outdated.
ssnl
approved these changes
Feb 19, 2019
| tensor([ 1, 2, 0, 0]) | ||
| >>> torch.multinomial(weights, 2) | ||
| tensor([1, 2]) | ||
| >>> torch.multinomial(weights, 4) # ERROR! |
Collaborator
There was a problem hiding this comment.
I'd add a few words explaining the error. Adding the error message here would also be useful.
ailzhang
force-pushed
the
update_multinomial_doc
branch
from
39a46e6 to
83291b5
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
pushed a commit
to ezyang/pytorch
that referenced
this pull request
Feb 19, 2019
Summary: Update documentation to raise awareness of the fix in pytorch#12490. Thanks matteorr for pointing this out! Pull Request resolved: pytorch#17269 Reviewed By: ezyang Differential Revision: D14138421 Pulled By: ailzhang fbshipit-source-id: 6433f9807a6ba1d871eba8e9d37aa6b78fa1e1fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation to raise awareness of the fix in #12490. Thanks @matteorr for pointing this out!