Skip to content

Make torch_nvshmem depends on libtorch_cpu#169905

Closed
ngimel wants to merge 2 commits intomainfrom
ngimel/nvshmem_dep
Closed

Make torch_nvshmem depends on libtorch_cpu#169905
ngimel wants to merge 2 commits intomainfrom
ngimel/nvshmem_dep

Conversation

@ngimel
Copy link
Collaborator

@ngimel ngimel commented Dec 9, 2025 •
edited by malfet
Loading

As it includes ATen headers and relies on some primitives

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 9, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169905

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 784e69f with merge base e51bd3c (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ngimel ngimel requested a review from malfet December 9, 2025 00:31
@malfet malfet changed the title add libtorch_cpu to torch_nvshmem to make ATen headers available Make torch_nvshmem depends on libtorch_cpu Dec 9, 2025
@malfet malfet added release notes: build release notes category topic: bug fixes topic category and removed topic: not user facing topic category labels Dec 9, 2025
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 9, 2025
@malfet
Copy link
Contributor

malfet commented Dec 9, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 9, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (distributed, 3, 3, linux.rocm.gpu.gfx942.4)

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Contributor

malfet commented Dec 9, 2025

@pytorchbot merge -f "Is it just me, or ROCM is always broken today"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

liangxs pushed a commit to liangxs/pytorch that referenced this pull request Dec 9, 2025
@ngimel
Make torch_nvshmem depends on libtorch_cpu (pytorch#169905)
fe97985 
As it includes ATen headers and relies on some primitives
Pull Request resolved: pytorch#169905
Approved by: https://github.com/malfet, https://github.com/jathu
skpark-rh pushed a commit to skpark-rh/pytorch that referenced this pull request Dec 10, 2025
@ngimel @skpark-rh
Make torch_nvshmem depends on libtorch_cpu (pytorch#169905)
a2982d9 
As it includes ATen headers and relies on some primitives
Pull Request resolved: pytorch#169905
Approved by: https://github.com/malfet, https://github.com/jathu
@github-actions github-actions bot deleted the ngimel/nvshmem_dep branch January 9, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@jathu jathu jathu approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: build release notes category topic: bug fixes topic category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ngimel @malfet @pytorchmergebot @jathu