[MPS][Inductor] Add _print_Where method to MetalExprPrinter for ReflectionPad support#169648
Closed
lingebeng wants to merge 2 commits intopytorch:mainfrom
Closed
[MPS][Inductor] Add _print_Where method to MetalExprPrinter for ReflectionPad support#169648lingebeng wants to merge 2 commits intopytorch:mainfrom
lingebeng wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169648
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 32c113e with merge base 7375582 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
added
topic: bug fixes
Contributor
|
@lingebeng Let's wait for CI, but something tells me you'll have to uncomment one of |
malfet
added
the
triaged
malfet
approved these changes
Dec 5, 2025
Contributor
|
@pytorchbot merge -f "Lint + MPS are green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
umechand-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Dec 8, 2025
…ctionPad support (pytorch#169648) The `MetalExprPrinter` class was missing a `_print_Where()` method, causing sympy `Where` expressions to be emitted as raw `Where(...)` function calls in generated Metal Shading Language (MSL) code. Since `Where` is not a standard MSL function,compilation failed with "undeclared identifier 'Where'" error. This PR adds the missing `_print_Where()` method to convert `Where(condition, true_val, false_val)` to Metal's C-style ternary operator `condition ? true_val : false_val`, following the same pattern as `CppPrinter`. Fixes pytorch#169643 Pull Request resolved: pytorch#169648 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
JacobSzwejbka
pushed a commit
that referenced
this pull request
Dec 8, 2025
…ctionPad support (#169648) The `MetalExprPrinter` class was missing a `_print_Where()` method, causing sympy `Where` expressions to be emitted as raw `Where(...)` function calls in generated Metal Shading Language (MSL) code. Since `Where` is not a standard MSL function,compilation failed with "undeclared identifier 'Where'" error. This PR adds the missing `_print_Where()` method to convert `Where(condition, true_val, false_val)` to Metal's C-style ternary operator `condition ? true_val : false_val`, following the same pattern as `CppPrinter`. Fixes #169643 Pull Request resolved: #169648 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MetalExprPrinterclass was missing a_print_Where()method, causing sympyWhereexpressions to be emitted as rawWhere(...)function calls in generated Metal Shading Language (MSL) code. SinceWhereis not a standard MSL function,compilation failed with "undeclared identifier 'Where'" error.This PR adds the missing
_print_Where()method to convertWhere(condition, true_val, false_val)to Metal's C-style ternary operatorcondition ? true_val : false_val, following the same pattern asCppPrinter.Fixes #169643
cc @kulinseth @malfet @DenisVieriu97 @jhavukainen @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo