Conversation
|
This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @robieta, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team. |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169514
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 345ef43 with merge base 213e0e8 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: A value intended for `GemmConfig.group_m` was being sent to `hint_override` as a positional argument. I made both keyword only so dataclasses will ensure the correct behavior. Test Plan: Assert trips when only the `dataclasses.field`s are added, but compilation succeeds when group_m is passed as kw. Reviewed By: PaulZhang12, njriasan Differential Revision: D88305338
d6740ad to
dbee8c7
Compare
dbee8c7 to
31e193b
Compare
Summary: A value intended for `GemmConfig.group_m` was being sent to `hint_override` as a positional argument. I made both keyword only so dataclasses will ensure the correct behavior. Test Plan: Assert trips when only the `dataclasses.field`s are added, but compilation succeeds when group_m is passed as kw. Reviewed By: PaulZhang12, njriasan Differential Revision: D88305338
31e193b to
8782f6f
Compare
Summary: A value intended for `GemmConfig.group_m` was being sent to `hint_override` as a positional argument. I made both keyword only so dataclasses will ensure the correct behavior. Test Plan: Assert trips when only the `dataclasses.field`s are added, but compilation succeeds when group_m is passed as kw. Reviewed By: PaulZhang12, njriasan Differential Revision: D88305338
Summary: A value intended for `GemmConfig.group_m` was being sent to `hint_override` as a positional argument. I made both keyword only so dataclasses will ensure the correct behavior. Test Plan: Assert trips when only the `dataclasses.field`s are added, but compilation succeeds when group_m is passed as kw. Reviewed By: PaulZhang12, njriasan Differential Revision: D88305338
8782f6f to
345ef43
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: Limited CI on H100 / linux-jammy-cuda12_8-py3_10-gcc11-sm90-FA3-ABI-stable-test / test Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "failing job is unrelated" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: A value intended for `GemmConfig.group_m` was being sent to `hint_override` as a positional argument. I made both keyword only so dataclasses will ensure the correct behavior. Test Plan: Assert trips when only the `dataclasses.field`s are added, but compilation succeeds when group_m is passed as kw. Differential Revision: D88305338 Pull Request resolved: pytorch#169514 Approved by: https://github.com/PaulZhang12
Summary: A value intended for
GemmConfig.group_mwas being sent tohint_overrideas a positional argument. I made both keyword only so dataclasses will ensure the correct behavior.Test Plan: Assert trips when only the
dataclasses.fields are added, but compilation succeeds when group_m is passed as kw.Differential Revision: D88305338
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo @mlazos