Skip to content

Fix Triton group_m config#169514

Closed
robieta wants to merge 1 commit intopytorch:mainfrom
robieta:export-D88305338
Closed

Fix Triton group_m config#169514
robieta wants to merge 1 commit intopytorch:mainfrom
robieta:export-D88305338

Conversation

@robieta
Copy link
Contributor

@robieta robieta commented Dec 3, 2025

Summary: A value intended for GemmConfig.group_m was being sent to hint_override as a positional argument. I made both keyword only so dataclasses will ensure the correct behavior.

Test Plan: Assert trips when only the dataclasses.fields are added, but compilation succeeds when group_m is passed as kw.

Differential Revision: D88305338

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo @mlazos

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 3, 2025

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @robieta, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169514

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 345ef43 with merge base 213e0e8 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-codesync
Copy link

meta-codesync bot commented Dec 3, 2025

@robieta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88305338.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 3, 2025
robieta added a commit to robieta/pytorch that referenced this pull request Dec 3, 2025
Summary:

A value intended for `GemmConfig.group_m` was being sent to `hint_override` as a positional argument. I made both keyword only so dataclasses will ensure the correct behavior.

Test Plan: Assert trips when only the `dataclasses.field`s are added, but compilation succeeds when group_m is passed as kw.

Reviewed By: PaulZhang12, njriasan

Differential Revision: D88305338
robieta added a commit to robieta/pytorch that referenced this pull request Dec 4, 2025
Summary:

A value intended for `GemmConfig.group_m` was being sent to `hint_override` as a positional argument. I made both keyword only so dataclasses will ensure the correct behavior.

Test Plan: Assert trips when only the `dataclasses.field`s are added, but compilation succeeds when group_m is passed as kw.

Reviewed By: PaulZhang12, njriasan

Differential Revision: D88305338
@pytorch-bot pytorch-bot bot added ciflow/b200 ciflow/h100 ciflow/rocm Trigger "default" config CI on ROCm labels Dec 4, 2025
pytorch-bot bot pushed a commit that referenced this pull request Dec 5, 2025
Summary:

A value intended for `GemmConfig.group_m` was being sent to `hint_override` as a positional argument. I made both keyword only so dataclasses will ensure the correct behavior.

Test Plan: Assert trips when only the `dataclasses.field`s are added, but compilation succeeds when group_m is passed as kw.

Reviewed By: PaulZhang12, njriasan

Differential Revision: D88305338
Summary:

A value intended for `GemmConfig.group_m` was being sent to `hint_override` as a positional argument. I made both keyword only so dataclasses will ensure the correct behavior.

Test Plan: Assert trips when only the `dataclasses.field`s are added, but compilation succeeds when group_m is passed as kw.

Reviewed By: PaulZhang12, njriasan

Differential Revision: D88305338
@robieta
Copy link
Contributor Author

robieta commented Dec 8, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: Limited CI on H100 / linux-jammy-cuda12_8-py3_10-gcc11-sm90-FA3-ABI-stable-test / test

Details for Dev Infra team Raised by workflow job

@robieta
Copy link
Contributor Author

robieta commented Dec 9, 2025

@pytorchbot merge -f "failing job is unrelated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

skpark-rh pushed a commit to skpark-rh/pytorch that referenced this pull request Dec 10, 2025
Summary: A value intended for `GemmConfig.group_m` was being sent to `hint_override` as a positional argument. I made both keyword only so dataclasses will ensure the correct behavior.

Test Plan: Assert trips when only the `dataclasses.field`s are added, but compilation succeeds when group_m is passed as kw.

Differential Revision: D88305338

Pull Request resolved: pytorch#169514
Approved by: https://github.com/PaulZhang12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants