Skip to content

[MPS] Migrate remaining clamp ops to Metal#169478

Closed
kurtamohler wants to merge 1 commit intogh/kurtamohler/67/basefrom
gh/kurtamohler/67/head
Closed

[MPS] Migrate remaining clamp ops to Metal#169478
kurtamohler wants to merge 1 commit intogh/kurtamohler/67/basefrom
gh/kurtamohler/67/head

Conversation

@kurtamohler
Copy link
Collaborator

@kurtamohler kurtamohler commented Dec 3, 2025 •
edited
Loading

@kurtamohler
Update
6e5fc99 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169478

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 6e5fc99 with merge base c6ae757 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Dec 3, 2025
kurtamohler added a commit that referenced this pull request Dec 3, 2025
@kurtamohler
[MPS] Migrate remaining clamp ops to Metal
ed8e8b7 
ghstack-source-id: 7d34ad0
Pull-Request: #169478
@kurtamohler kurtamohler mentioned this pull request Dec 3, 2025
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

@malfet malfet added the topic: improvements topic category label Dec 5, 2025
@malfet
Copy link
Contributor

malfet commented Dec 5, 2025

@pytorchbot merge -f "Lint + MPS are green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 5, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

umechand-amd pushed a commit to ROCm/pytorch that referenced this pull request Dec 8, 2025
@kurtamohler
[MPS] Migrate remaining clamp ops to Metal (pytorch#169478)
5ae95c7 
Pull Request resolved: pytorch#169478
Approved by: https://github.com/malfet
ghstack dependencies: pytorch#169407
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
@kurtamohler @JacobSzwejbka
[MPS] Migrate remaining clamp ops to Metal (#169478)
3798c6e 
Pull Request resolved: #169478
Approved by: https://github.com/malfet
ghstack dependencies: #169407
@github-actions github-actions bot deleted the gh/kurtamohler/67/head branch January 5, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged open source release notes: mps Release notes category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kurtamohler @malfet @pytorchmergebot @pytorchbot