Skip to content

[MPS] Index select mps sparse#169368

Closed
Isalia20 wants to merge 11 commits intopytorch:mainfrom
Isalia20:index-select-mps-sparse
Closed

[MPS] Index select mps sparse#169368
Isalia20 wants to merge 11 commits intopytorch:mainfrom
Isalia20:index-select-mps-sparse

Conversation

@Isalia20
Copy link
Collaborator

@Isalia20 Isalia20 commented Dec 2, 2025

Should be merged after:
#168902
Will rebase once that's merged

@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Dec 2, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169368

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 22bce3f with merge base 5fed0c4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Isalia20 Isalia20 requested a review from malfet December 2, 2025 11:31
@Isalia20 Isalia20 added release notes: mps Release notes category topic: improvements topic category labels Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 4, 2025
@Isalia20 Isalia20 added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 5, 2025
@malfet
Copy link
Contributor

malfet commented Dec 5, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 5, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

umechand-amd pushed a commit to ROCm/pytorch that referenced this pull request Dec 8, 2025
@Isalia20
[MPS] Index select mps sparse (pytorch#169368)
91d0276 
Should be merged after:
pytorch#168902
Will rebase once that's merged
Pull Request resolved: pytorch#169368
Approved by: https://github.com/malfet
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
@Isalia20 @JacobSzwejbka
[MPS] Index select mps sparse (#169368)
c6f6ba0 
Should be merged after:
#168902
Will rebase once that's merged
Pull Request resolved: #169368
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category release notes: sparse release notes category topic: improvements topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Isalia20 @malfet @pytorchmergebot @pytorchbot @mikaylagawarecki