Skip to content

[MPS] Sparse mps backward sum#169240

Closed
Isalia20 wants to merge 10 commits intopytorch:mainfrom
Isalia20:sparse-mps-backward-sum
Closed

[MPS] Sparse mps backward sum#169240
Isalia20 wants to merge 10 commits intopytorch:mainfrom
Isalia20:sparse-mps-backward-sum

Conversation

@Isalia20
Copy link
Collaborator

Implement sparse sum backwards for mps device
Should be merged after:
#168902

Will rebase once that one is merged

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169240

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3500d9d with merge base 50e1cc3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Nov 29, 2025
@Isalia20 Isalia20 requested a review from malfet November 29, 2025 16:51
@Isalia20 Isalia20 added the topic: improvements topic category label Nov 29, 2025
@github-actions
Copy link
Contributor

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.


Caused by:

@jcaip jcaip added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 4, 2025
@Isalia20 Isalia20 added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 6, 2025
@malfet
Copy link
Contributor

malfet commented Dec 8, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

umechand-amd pushed a commit to ROCm/pytorch that referenced this pull request Dec 8, 2025
Implement sparse sum backwards for mps device
Should be merged after:
pytorch#168902

Will rebase once that one is merged
Pull Request resolved: pytorch#169240
Approved by: https://github.com/malfet
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
Implement sparse sum backwards for mps device
Should be merged after:
#168902

Will rebase once that one is merged
Pull Request resolved: #169240
Approved by: https://github.com/malfet
liangxs pushed a commit to liangxs/pytorch that referenced this pull request Dec 9, 2025
Implement sparse sum backwards for mps device
Should be merged after:
pytorch#168902

Will rebase once that one is merged
Pull Request resolved: pytorch#169240
Approved by: https://github.com/malfet
skpark-rh pushed a commit to skpark-rh/pytorch that referenced this pull request Dec 10, 2025
Implement sparse sum backwards for mps device
Should be merged after:
pytorch#168902

Will rebase once that one is merged
Pull Request resolved: pytorch#169240
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: sparse release notes category topic: improvements topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants