Fix an unsafe indexing in fx exception handling#169140
Fix an unsafe indexing in fx exception handling#169140gmagogsfm wants to merge 1 commit intopytorch:mainfrom
Conversation
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169140
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
gmagogsfm
added
release notes: not needed
and removed
release notes: fx
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge -f "ROCM pending" |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Inspired by #169140, without checking if the args tuple is empty, which could lead to IndexError and mask the actual error. Pull Request resolved: #169234 Approved by: https://github.com/Lucaskabela
There is an unsafe indexing into `e.args` in FX's exception handling, which would lead to nested exception and mask the actual error. This PR fixes it. Pull Request resolved: #169140 Approved by: https://github.com/cyyever, https://github.com/Skylion007
Inspired by #169140, without checking if the args tuple is empty, which could lead to IndexError and mask the actual error. Pull Request resolved: #169234 Approved by: https://github.com/Lucaskabela
5 participants
There is an unsafe indexing into
e.argsin FX's exception handling, which would lead to nested exception and mask the actual error. This PR fixes it.cc @ezyang @EikanWang @jgong5 @wenzhe-nrv