dist/debug: add TCPStore debug page#169095
Closed
d4l3k wants to merge 4 commits intogh/d4l3k/2/basefrom
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169095
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a2ed8b7 with merge base 641cdb6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
fduwjj
approved these changes
Nov 26, 2025
This was referenced Nov 26, 2025
Collaborator
|
Starting merge as part of PR stack under #169096 |
2 similar comments
Collaborator
|
Starting merge as part of PR stack under #169096 |
Collaborator
|
Starting merge as part of PR stack under #169096 |
Collaborator
|
Starting merge as part of PR stack under #169096 |
Collaborator
|
Starting merge as part of PR stack under #169147 |
Collaborator
|
Starting merge as part of PR stack under #169144 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 2, 2025
This uses `aiohttp` to run all requests concurrently. This cuts the latency at 10k from `15s -> 5s` and is `50s` at 100k. I expect that 100k number is a little sus given I was running this on a single machine with only 4 workers. Test plan: patch fetch_all to do 100k requests instead Pull Request resolved: #169096 Approved by: https://github.com/fduwjj ghstack dependencies: #169095
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 2, 2025
This adds FlightRecorder trace analysis using frtrace to the debug server. Test plan: <img width="2875" height="1295" alt="20251126_14h58m19s_grim" src="https://github.com/user-attachments/assets/4f285405-0f2f-4988-871f-85af1fe286b3" /> Pull Request resolved: #169144 Approved by: https://github.com/fduwjj ghstack dependencies: #169095, #169096
JacobSzwejbka
pushed a commit
that referenced
this pull request
Dec 8, 2025
This adds a TCPStore debug page. Test plan: run debug server [ <img width="1412" height="617" alt="20251125_17h23m00s_grim" src="https://github.com/user-attachments/assets/8557b239-c397-4d37-ae04-53a42d4096da" /> ](url) Pull Request resolved: #169095 Approved by: https://github.com/fduwjj
JacobSzwejbka
pushed a commit
that referenced
this pull request
Dec 8, 2025
This uses `aiohttp` to run all requests concurrently. This cuts the latency at 10k from `15s -> 5s` and is `50s` at 100k. I expect that 100k number is a little sus given I was running this on a single machine with only 4 workers. Test plan: patch fetch_all to do 100k requests instead Pull Request resolved: #169096 Approved by: https://github.com/fduwjj ghstack dependencies: #169095
JacobSzwejbka
pushed a commit
that referenced
this pull request
Dec 8, 2025
This adds FlightRecorder trace analysis using frtrace to the debug server. Test plan: <img width="2875" height="1295" alt="20251126_14h58m19s_grim" src="https://github.com/user-attachments/assets/4f285405-0f2f-4988-871f-85af1fe286b3" /> Pull Request resolved: #169144 Approved by: https://github.com/fduwjj ghstack dependencies: #169095, #169096
tiendatngcs
pushed a commit
to tiendatngcs/pytorch-Dec25
that referenced
this pull request
Dec 10, 2025
ghstack-source-id: 976ea5c Pull-Request: pytorch/pytorch#169095
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a TCPStore debug page.
Stack from ghstack (oldest at bottom):
Test plan:
run debug server