Skip to content

Type annotations for torch/_higher_order_ops/flat_apply.py#168933

Closed
aorenste wants to merge 4 commits intogh/aorenste/150/basefrom
gh/aorenste/150/head
Closed

Type annotations for torch/_higher_order_ops/flat_apply.py#168933
aorenste wants to merge 4 commits intogh/aorenste/150/basefrom
gh/aorenste/150/head

Conversation

@aorenste
Copy link
Contributor

@aorenste aorenste commented Nov 23, 2025 •
edited
Loading

@aorenste
Type annotations
871e932 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168933

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8311576 with merge base 9f7c46b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Nov 23, 2025
This was referenced Nov 23, 2025
Closed
Closed
@aorenste aorenste changed the title Type annotations Type annotations for torch/_higher_order_ops/flat_apply.py Nov 24, 2025
@aorenste aorenste requested a review from anijain2305 November 24, 2025 18:14
@aorenste aorenste marked this pull request as ready for review November 24, 2025 18:14
@aorenste aorenste requested a review from zou3519 as a code owner November 24, 2025 18:15
Skylion007
Skylion007 reviewed Nov 24, 2025
View reviewed changes
Copy link
Collaborator

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typing nits to improve the typing further

Skylion007
Skylion007 reviewed Nov 24, 2025
View reviewed changes
Skylion007
Skylion007 reviewed Nov 24, 2025
View reviewed changes
Skylion007
Skylion007 reviewed Nov 25, 2025
View reviewed changes
@aorenste
Update on "Type annotations for torch/_higher_order_ops/flat_apply.py"
8119df9 


cc ezyang EikanWang jgong5 wenzhe-nrv

[ghstack-poisoned]
@aorenste
Copy link
Contributor Author

aorenste commented Dec 1, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 1, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 1, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 1, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 6, 6, linux.rocm.gpu.gfx942.1)

Details for Dev Infra team Raised by workflow job

@aorenste
Update on "Type annotations for torch/_higher_order_ops/flat_apply.py"
75dbf11 


cc ezyang EikanWang jgong5 wenzhe-nrv

[ghstack-poisoned]
@aorenste
Update on "Type annotations for torch/_higher_order_ops/flat_apply.py"
8311576 


cc ezyang EikanWang jgong5 wenzhe-nrv

[ghstack-poisoned]
@aorenste
Copy link
Contributor Author

aorenste commented Dec 5, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 5, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

umechand-amd pushed a commit to ROCm/pytorch that referenced this pull request Dec 8, 2025
@aorenste
Type annotations for torch/_higher_order_ops/flat_apply.py (pytorch#1…
739c9d6 
…68933)

Pull Request resolved: pytorch#168933
Approved by: https://github.com/zou3519, https://github.com/anijain2305
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
@aorenste @JacobSzwejbka
Type annotations for torch/_higher_order_ops/flat_apply.py (#168933)
ae24c5b 
Pull Request resolved: #168933
Approved by: https://github.com/zou3519, https://github.com/anijain2305
tiendatngcs pushed a commit to tiendatngcs/pytorch-Dec25 that referenced this pull request Dec 10, 2025
@aorenste
Type annotations
a8096d5 
ghstack-source-id: 776002c
Pull Request resolved: pytorch/pytorch#168933
@github-actions github-actions bot deleted the gh/aorenste/150/head branch January 5, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@zou3519 zou3519 zou3519 approved these changes

@anijain2305 anijain2305 anijain2305 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fx Merged release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aorenste @pytorchmergebot @Skylion007 @zou3519 @anijain2305 @facebook-github-bot