Skip to content

Add allgather_base and reduce_scatter_base collective implementations to Local Tensor#168314

Closed
dzmitry-huba wants to merge 2 commits intogh/dzmitry-huba/15/basefrom
gh/dzmitry-huba/15/head
Closed

Add allgather_base and reduce_scatter_base collective implementations to Local Tensor#168314
dzmitry-huba wants to merge 2 commits intogh/dzmitry-huba/15/basefrom
gh/dzmitry-huba/15/head

Conversation

@dzmitry-huba
Copy link
Contributor

@dzmitry-huba dzmitry-huba commented Nov 21, 2025

Both collectives are required to run FSDPv2 under local tensor

Stack from ghstack (oldest at bottom):

@pytorch-bot pytorch-bot bot added the release notes: distributed (c10d) release notes category label Nov 21, 2025
dzmitry-huba added a commit that referenced this pull request Nov 21, 2025
@dzmitry-huba dzmitry-huba requested review from ezyang and fegin November 21, 2025 00:05
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168314

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a7a18bd with merge base 6c02dde (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

dzmitry-huba added a commit that referenced this pull request Nov 21, 2025
… to Local Tensor

ghstack-source-id: 40ffb98
Pull Request resolved: #168314
@dzmitry-huba dzmitry-huba changed the title Add allgather_base collective implementation to Local Tensor Add allgather_base and reduce_scatter_base collective implementations to Local Tensor Nov 21, 2025
@dzmitry-huba dzmitry-huba requested a review from dolpm November 21, 2025 00:48
@dzmitry-huba
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 21, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

karthickai added a commit that referenced this pull request Nov 21, 2025
… to Local Tensor (#168314)

Both collectives are required to run FSDPv2 under local tensor

Pull Request resolved: #168314
Approved by: https://github.com/dolpm, https://github.com/ezyang
ghstack-source-id: 5420962
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
… to Local Tensor (#168314)

Both collectives are required to run FSDPv2 under local tensor

Pull Request resolved: #168314
Approved by: https://github.com/dolpm, https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (c10d) release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants