Skip to content

Revert C++ fastpath dispatch path for DTensor#168264

Closed
ezyang wants to merge 2 commits intogh/ezyang/3203/basefrom
gh/ezyang/3203/head
Closed

Revert C++ fastpath dispatch path for DTensor#168264
ezyang wants to merge 2 commits intogh/ezyang/3203/basefrom
gh/ezyang/3203/head

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Nov 20, 2025 •
edited by seemethere
Loading

Stack from ghstack (oldest at bottom):

git revert --no-commit 567dcdba757 200156e3850 3d801a4c01f 2034ca99ae7 480b4ff8828 f570e589da1

And Revert "[DTensor] Document fast-path dispatch (#168192)"
And Revert "[DTensor] Fix deadlock after fast cache clear (#168069)"

Reverts:

Signed-off-by: Edward Z. Yang ezyang@meta.com

cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel

@ezyang
Update
1ab2e11 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168264

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 2 Pending, 1 Unrelated Failure

As of commit abadbce with merge base 05b1119 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Nov 20, 2025
@ezyang
Revert C++ fastpath dispatch path for DTensor
716abe1 
```
git revert --no-commit 567dcdb 200156e 3d801a4 2034ca9 480b4ff f570e58
```

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
ghstack-source-id: 82bc378
Pull-Request: #168264
@pytorch-bot pytorch-bot bot added ci-no-td Do not run TD on this PR ciflow/inductor release notes: jit release notes category labels Nov 20, 2025
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Nov 20, 2025
@pytorch-bot pytorch-bot bot removed the oncall: jit Add this issue/PR to JIT oncall triage queue label Nov 20, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 20, 2025

The label oncall: jit is only applicable to issues and has been removed. Please only use this label on issues.

@ezyang
Update
abadbce 
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Nov 20, 2025
@ezyang
Revert C++ fastpath dispatch path for DTensor
4c1b5a8 
```
git revert --no-commit 567dcdb 200156e 3d801a4 2034ca9 480b4ff f570e58
```

And Revert "[DTensor] Document fast-path dispatch (#168192)"
And Revert "[DTensor] Fix deadlock after fast cache clear (#168069)"

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
ghstack-source-id: 25bd260
Pull-Request: #168264
@ezyang ezyang added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 20, 2025
@ezyang
Copy link
Contributor Author

ezyang commented Nov 20, 2025

@pytorchbot merge

@seemethere
Copy link
Member

seemethere commented Nov 20, 2025

Can we link all of the PRs that this reverts?

@ezyang
Copy link
Contributor Author

ezyang commented Nov 20, 2025

done

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 20, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 21, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 2, 6, linux.rocm.gpu.gfx942.1)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Nov 21, 2025

@pytorchbot merge -f "rocm only"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 21, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ezyang added a commit that referenced this pull request Nov 21, 2025
@ezyang
Reapply "C++ fastpath dispatch path for DTensor (#168264)"
b06daf4 
This reverts commit 8ad78bb.


ghstack-source-id: 9799c44
Pull-Request: #168330
@ezyang ezyang mentioned this pull request Nov 21, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Nov 21, 2025
@ezyang @pytorchmergebot
Revert #168264 + Python-side LRU cache when native op schema is not s…
d4de871 
…upported (#168269)

This reverts #168264 but with a bugfix for the reason why it was reverted.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: #168269
Approved by: https://github.com/wconstab, https://github.com/albanD, https://github.com/zpcore, https://github.com/malfet
@ezyang ezyang mentioned this pull request Nov 21, 2025
Closed
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
@ezyang @JacobSzwejbka
Revert C++ fastpath dispatch path for DTensor (#168264)
15f13a4 
```
git revert --no-commit 567dcdb 200156e 3d801a4 2034ca9 480b4ff f570e58
```

    And Revert "[DTensor] Document fast-path dispatch (#168192)"
    And Revert "[DTensor] Fix deadlock after fast cache clear (#168069)"

Reverts:
* #167860
* #167588
* #167475
* #166808
* #166372
* #168192
* #168069

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: #168264
Approved by: https://github.com/seemethere, https://github.com/malfet
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
@ezyang @JacobSzwejbka
Revert #168264 + Python-side LRU cache when native op schema is not s…
bb4d24d 
…upported (#168269)

This reverts #168264 but with a bugfix for the reason why it was reverted.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: #168269
Approved by: https://github.com/wconstab, https://github.com/albanD, https://github.com/zpcore, https://github.com/malfet
@github-actions github-actions bot deleted the gh/ezyang/3203/head branch December 22, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@malfet malfet malfet approved these changes

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki

@albanD albanD Awaiting requested review from albanD

@soulitzer soulitzer Awaiting requested review from soulitzer

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: jit release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ezyang @seemethere @pytorchmergebot @malfet @facebook-github-bot