Skip to content

[ROCm][CI] Expand trunk.yml coverage for ROCm#168162

Closed
jithunnair-amd wants to merge 5 commits intopytorch:mainfrom
ROCm:swap_trunk_rocm_mi300_labels
Closed

[ROCm][CI] Expand trunk.yml coverage for ROCm#168162
jithunnair-amd wants to merge 5 commits intopytorch:mainfrom
ROCm:swap_trunk_rocm_mi300_labels

Conversation

@jithunnair-amd
Copy link
Collaborator

@jithunnair-amd jithunnair-amd commented Nov 19, 2025

We are expanding the test coverage on pre-submit (PR-based) trunk.yml runs for ROCm to the full list of unit tests.

Consequently, we are swapping the labels (CSPs) for the rocm-mi300.yml and periodic-rocm-mi300.yml workflows to balance capacity concerns.

We will be disabling the shadow workflow trunk-rocm-mi300.yml as it is not required due to this PR anymore.

Fixes #166108

cc @jeffdaily @sunway513 @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Nov 19, 2025
@jithunnair-amd jithunnair-amd changed the title [ROCm][CI] Swap labels for trunk-rocm-mi300.yml and (rocm-mi300.yml and periodic-rocm-mi300.yml) [ROCm][CI] Expand trunk.yml coverage for ROCm Nov 19, 2025
@jithunnair-amd jithunnair-amd added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 19, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168162

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit d5d9850 with merge base fb6af11 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jithunnair-amd jithunnair-amd added keep-going Don't stop on first failure, keep running tests until the end ci-no-td Do not run TD on this PR labels Nov 19, 2025
@jithunnair-amd
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #168162, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@jithunnair-amd jithunnair-amd marked this pull request as ready for review November 20, 2025 01:40
@jithunnair-amd jithunnair-amd requested a review from a team as a code owner November 20, 2025 01:40
pytorchmergebot pushed a commit that referenced this pull request Nov 20, 2025
…8202)

Needed due to #168162, which means rocm-mi300.yml (uses noble images) and periodic-rocm-mi300.yml (uses jammy images) will both run on the new MI3xx capacity.

Also re-enable `workflow_dispatch` with inputs required to run successfully

Pull Request resolved: #168202
Approved by: https://github.com/jeffdaily
@jithunnair-amd
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jithunnair-amd jithunnair-amd deleted the swap_trunk_rocm_mi300_labels branch November 20, 2025 05:10
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
…8202)

Needed due to #168162, which means rocm-mi300.yml (uses noble images) and periodic-rocm-mi300.yml (uses jammy images) will both run on the new MI3xx capacity.

Also re-enable `workflow_dispatch` with inputs required to run successfully

Pull Request resolved: #168202
Approved by: https://github.com/jeffdaily
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
We are expanding the test coverage on pre-submit (PR-based) trunk.yml runs for ROCm to the full list of unit tests.

Consequently, we are swapping the labels (CSPs) for the rocm-mi300.yml and periodic-rocm-mi300.yml workflows to balance capacity concerns.

We will be disabling the shadow workflow trunk-rocm-mi300.yml as it is not required due to this PR anymore.

Fixes #166108

Pull Request resolved: #168162
Approved by: https://github.com/jeffdaily
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add back ROCm trunk integration tests

4 participants