Skip to content

[MPS] Migrate lu_unpack to Metal and fix lu_solve backward#168120

Closed
kurtamohler wants to merge 4 commits intogh/kurtamohler/63/basefrom
gh/kurtamohler/63/head
Closed

[MPS] Migrate lu_unpack to Metal and fix lu_solve backward#168120
kurtamohler wants to merge 4 commits intogh/kurtamohler/63/basefrom
gh/kurtamohler/63/head

Conversation

@kurtamohler
Copy link
Collaborator

@kurtamohler kurtamohler commented Nov 18, 2025

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168120

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 99d7c70 with merge base c6ae757 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the ciflow/mps Run MPS tests (subset of trunk) label Nov 18, 2025
@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Nov 18, 2025
kurtamohler added a commit that referenced this pull request Nov 18, 2025
@github-actions
Copy link
Contributor

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.


Caused by:

[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Nov 19, 2025
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Nov 26, 2025
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Dec 3, 2025
@malfet malfet added the topic: improvements topic category label Dec 3, 2025
@malfet
Copy link
Contributor

malfet commented Dec 3, 2025

@pytorchbot megre -f "Lint + MPS are green"

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 3, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'megre' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

@kurtamohler
Copy link
Collaborator Author

@pytorchbot merge -f "Lint + MPS are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
@github-actions github-actions bot deleted the gh/kurtamohler/63/head branch January 4, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged open source release notes: mps Release notes category topic: improvements topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants