[MPS] Fix repeat_interleave with slices#167961
Closed
malfet wants to merge 2 commits intogh/malfet/606/basefrom
Closed
[MPS] Fix repeat_interleave with slices#167961malfet wants to merge 2 commits intogh/malfet/606/basefrom
malfet wants to merge 2 commits intogh/malfet/606/basefrom
Conversation
Alas, one can not use `repeat_interleave_common` for MPS tensors, as `data_offset` is not a valid pointer to `id<MTLTensor>` On the other hand, one does not need to use `AT_DISPATCH_INDEX_TYPES` as dispatching is happening on the shader side Fixes #167924 [ghstack-poisoned]
malfet
added a commit
that referenced
this pull request
Nov 17, 2025
Alas, one can not use `repeat_interleave_common` for MPS tensors, as `data_offset` is not a valid pointer to `id<MTLTensor>` On the other hand, one does not need to use `AT_DISPATCH_INDEX_TYPES` as dispatching is happening on the shader side Fixes #167924 ghstack-source-id: c04d33d Pull Request resolved: #167961
pytorch-bot
bot
added
ciflow/mps
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167961
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a50d5dc with merge base 98b94b9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Alas, one can not use `repeat_interleave_common` for MPS tensors, as `data_offset` is not a valid pointer to `id<MTLTensor>` On the other hand, one does not need to use `AT_DISPATCH_INDEX_TYPES` as dispatching is happening on the shader side Fixes #167924 [ghstack-poisoned]
malfet
added a commit
that referenced
this pull request
Nov 17, 2025
Alas, one can not use `repeat_interleave_common` for MPS tensors, as `data_offset` is not a valid pointer to `id<MTLTensor>` On the other hand, one does not need to use `AT_DISPATCH_INDEX_TYPES` as dispatching is happening on the shader side Fixes #167924 ghstack-source-id: 0b37a6a Pull Request resolved: #167961
manuelcandales
approved these changes
Nov 17, 2025
Contributor
Author
|
@pytorchbot merge -f "Lint + MPS are green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
Alas, one can not use `repeat_interleave_common` for MPS tensors, as `data_offset` is not a valid pointer to `id<MTLTensor>` On the other hand, one does not need to use `AT_DISPATCH_INDEX_TYPES` as dispatching is happening on the shader side Fixes pytorch#167924 Pull Request resolved: pytorch#167961 Approved by: https://github.com/manuelcandales
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Alas, one can not use
repeat_interleave_commonfor MPS tensors, asdata_offsetis not a valid pointer toid<MTLTensor>On the other hand, one does not need to use
AT_DISPATCH_INDEX_TYPESas dispatching is happening on the shader sideFixes #167924